Skip to content

Conversation

@Kkaiwz
Copy link
Contributor

@Kkaiwz Kkaiwz commented Dec 16, 2025

Fix the random crash caused by free a non‑null garbage value. This patch is the improvement of PR:#1453

Description

After (#1453), still meet random crash. So we need to initialize all the handles that will be free in the destructor.

Please include a summary of the change, new sample or fixed issue. Please also include relevant motivation and context.
Please read the contribution guidelines

Fixes #

General Checklist:

Please ensure the following points are checked:

  • My code follows the coding style
  • I have reviewed file licenses
  • I have commented any added functions (in line with Doxygen)
  • I have commented any code that could be hard to understand
  • My changes do not add any new compiler warnings
  • My changes do not add any new validation layer errors or warnings
  • I have used existing framework/helper functions where possible
  • My changes do not add any regressions
  • I have tested every sample to ensure everything runs correctly
  • This PR describes the scope and expected impact of the changes I am making

Note: The Samples CI runs a number of checks including:

  • I have updated the header Copyright to reflect the current year (CI build will fail if Copyright is out of date)
  • My changes build on Windows, Linux, macOS and Android. Otherwise I have documented any exceptions

If this PR contains framework changes:

  • I did a full batch run using the batch command line argument to make sure all samples still work properly

Sample Checklist

If your PR contains a new or modified sample, these further checks must be carried out in addition to the General Checklist:

  • I have tested the sample on at least one compliant Vulkan implementation
  • If the sample is vendor-specific, I have tagged it appropriately
  • I have stated on what implementation the sample has been tested so that others can test on different implementations and platforms
  • Any dependent assets have been merged and published in downstream modules
  • For new samples, I have added a paragraph with a summary to the appropriate chapter in the readme of the folder that the sample belongs to e.g. api samples readme
  • For new samples, I have added a tutorial README.md file to guide users through what they need to know to implement code using this feature. For example, see conditional_rendering
  • For new samples, I have added a link to the Antora navigation so that the sample will be listed at the Vulkan documentation site

@Kkaiwz Kkaiwz force-pushed the bugfix/Initalize-all-handle-which-free-in-destructor branch 2 times, most recently from f67eb72 to 8733478 Compare December 16, 2025 10:37
Fix the random crash caused by free a non‑null garbage value.
This patch is the improvement of PR:KhronosGroup#1453

Signed-off-by: Ryan Zhang <ryan.zhang@nxp.com>
@Kkaiwz Kkaiwz force-pushed the bugfix/Initalize-all-handle-which-free-in-destructor branch from 8733478 to 136dd49 Compare December 16, 2025 10:42
Copy link
Collaborator

@SaschaWillems SaschaWillems left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants