Skip to content

Conversation

@gpx1000
Copy link
Contributor

@gpx1000 gpx1000 commented Jul 5, 2025

  • Set up MSAA sample count using getMaxUsableSampleCount() and integrate it throughout the pipeline.
  • Add support for depth attachment in the pipeline with appropriate format detection.
  • Refactor image layout transitions to handle color, depth, and multisampled images.
  • Introduce transition_image_layout_custom() for flexible image layout transitions.
  • Update rendering pass to include multisampled color and depth attachments with clear values.

- Set up MSAA sample count using `getMaxUsableSampleCount()` and integrate it throughout the pipeline.
- Add support for depth attachment in the pipeline with appropriate format detection.
- Refactor image layout transitions to handle color, depth, and multisampled images.
- Introduce `transition_image_layout_custom()` for flexible image layout transitions.
- Update rendering pass to include multisampled color and depth attachments with clear values.
@gpx1000 gpx1000 linked an issue Jul 5, 2025 that may be closed by this pull request
- Integrate depth attachment format detection into pipeline setup.
- Transition depth images to optimal layouts for depth/stencil usage.
- Include depth attachment in rendering configuration with appropriate clear values.
Copy link
Collaborator

@SaschaWillems SaschaWillems left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍🏻

@gpx1000 gpx1000 merged commit 8907b64 into KhronosGroup:main Jul 6, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Multisampling chapter code no longer doing multisampling Depth buffering no longer working

2 participants