Skip to content

Tune caching Snowflake data #4237

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
chrarnoldus wants to merge 1 commit into
base: main
Choose a base branch
from
+5 −3
Open

Tune caching Snowflake data #4237

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions apps/web/src/lib/public-snowflake-report.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,9 @@ const CORS_HEADERS = {
'Access-Control-Allow-Methods': 'GET',
'Access-Control-Allow-Headers': 'Content-Type',
};
const CACHE_TTL_SECONDS = 60;

const VERCEL_CACHE_TTL_SECONDS = 60;
const REDIS_CACHE_TTL_SECONDS = 3600;

type PublicSnowflakeReportOptions<Usage> = {
cacheKey: RedisKey;
Expand All @@ -26,7 +28,7 @@ function successResponse<Usage>(usage: Usage): NextResponse {
return NextResponse.json(usage, {
headers: {
...CORS_HEADERS,
'Cache-Control': `public, s-maxage=${CACHE_TTL_SECONDS}`,
'Cache-Control': `public, s-maxage=${VERCEL_CACHE_TTL_SECONDS}, stale-while-revalidate=${VERCEL_CACHE_TTL_SECONDS}`,
},
});
}
Expand Down Expand Up @@ -71,7 +73,7 @@ export async function getPublicSnowflakeReport<Usage>({

try {
await redisClient.set(cacheKey, JSON.stringify(usage), {
ex: CACHE_TTL_SECONDS,
ex: REDIS_CACHE_TTL_SECONDS,
});
} catch (error) {
captureException(error, {
Expand Down