fix(o11y): parse Analytics Engine aggregate strings#4244
Merged
Conversation
Contributor
Code Review SummaryStatus: No Issues Found | Recommendation: Merge Files Reviewed (2 files)
Reviewed by gpt-5.4-20260305 · Input: 41.1K · Output: 5.4K · Cached: 309.8K Review guidance: REVIEW.md from base branch |
eshurakov
approved these changes
Jun 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Parses Analytics Engine aggregate strings before validating Gastown health metrics.
Why this change is needed
Cloudflare Analytics Engine serializes
SUM(...)values as strings in JSON. The o11y worker expected JSON numbers, so every Gastown health evaluation failed schema validation after the cardinality fix reached production.How this is addressed
Human Verification
SUM(...)fields arrive as strings.Reviewer Notes
Human Reviewer Flags
No notable items for human review beyond what the summary covers.
Code Reviewer Agent
Code Reviewer Notes
number | null, preserving downstream metric contracts.