Skip to content

fix(config): add notebook permission schema#4250

Merged
markijbema merged 1 commit into
mainfrom
mark/notebook-permission-schema
Jun 25, 2026
Merged

fix(config): add notebook permission schema#4250
markijbema merged 1 commit into
mainfrom
mark/notebook-permission-schema

Conversation

@markijbema

Copy link
Copy Markdown
Contributor

Summary

  • Add notebook_read, notebook_edit, and notebook_execute to Kilo's published CLI permission schema.
  • Extend the upstream schema overlay to merge Kilo permission definitions without dropping existing permission keys.
  • Add regression coverage for the nested PermissionConfig merge.

Verification

  • N/A — schema-only change with no manual user flow.

Visual Changes

N/A

Reviewer Notes

Follow-up for Kilo-Org/kilocode#11644 discussion_r3473007520.

Co-authored-by: kiloconnect[bot] <240665456+kiloconnect[bot]@users.noreply.github.com>
@kilo-code-bot

kilo-code-bot Bot commented Jun 25, 2026

Copy link
Copy Markdown
Contributor

Code Review Summary

Status: No Issues Found | Recommendation: Merge

Files Reviewed (3 files)
  • apps/web/src/app/config.json/extras.ts
  • apps/web/src/app/config.json/route.ts
  • apps/web/src/tests/cli-config-schema.test.ts

Reviewed by gpt-5.4-20260305 · Input: 34.9K · Output: 5.5K · Cached: 208.7K

Review guidance: REVIEW.md from base branch main

@markijbema markijbema enabled auto-merge (squash) June 25, 2026 08:50
@markijbema markijbema merged commit bcfa10e into main Jun 25, 2026
16 checks passed
@markijbema markijbema deleted the mark/notebook-permission-schema branch June 25, 2026 08:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants