fix(a11y): repair app shell landmarks#4271
Merged
jeanduplessis merged 6 commits intoJun 26, 2026
Merged
Conversation
Contributor
Code Review SummaryStatus: No Issues Found | Recommendation: Merge Files Reviewed (3 files)
Previous Review Summaries (3 snapshots, latest commit 0da57bc)Current summary above is authoritative. Previous snapshots are kept for context only. Previous review (commit 0da57bc)Status: No Issues Found | Recommendation: Merge Files Reviewed (4 files)
Previous review (commit fe33592)Status: 1 Issue Found | Recommendation: Address before merge Overview
Issue Details (click to expand)WARNING
Fix these issues in Kilo Cloud Files Reviewed (1 file)
Previous review (commit 07b1b1e)Status: 1 Issue Found | Recommendation: Address before merge Overview
Issue Details (click to expand)WARNING
Fix these issues in Kilo Cloud Files Reviewed (19 files)
Reviewed by gpt-5.4-20260305 · Input: 68.7K · Output: 10.1K · Cached: 666.9K Review guidance: REVIEW.md from base branch |
pandemicsyn
approved these changes
Jun 26, 2026
pandemicsyn
left a comment
Contributor
There was a problem hiding this comment.
lgtm, couple of feedback items but pre-approved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Repairs app shell landmarks and keyboard navigation state across personal, organization, admin, Gastown, and Wasteland shells.
Why this change is needed
Issue #4182 identified app shell accessibility regressions: skip navigation was absent, shells exposed inconsistent main landmarks, current nav state was not announced reliably, and compact sidebar controls could be hard to target or verify.
How this is addressed
main#main-content.Closes #4182
Verification
Manual testing performed
Components/Layout/App Shelladmin and skip-link-focused stories.Visual Changes
Storybook stories added for
Components/Layout/App Shell; review in Storybook at those stories.Reviewer Notes
Human Reviewer
Code Reviewer Agent
Code Reviewer Notes
AppShellSkipLinkappears before shell content and targets#main-content.SidebarInsetno longer rendersmain; route layouts now provide the single main landmark.