Skip to content

feat(code-reviews): add manual jobs #4273

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
alex-alecu wants to merge 3 commits into
base: main
Choose a base branch
from
Open

feat(code-reviews): add manual jobs #4273

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
72fcba5
feat(code-reviews): add manual jobs
alex-alecu Jun 26, 2026
caeef16
fix(db): create indexes concurrently
alex-alecu Jun 26, 2026
5cbfe46
fix(code-reviews): create distinct manual jobs
alex-alecu Jun 26, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
30 changes: 22 additions & 8 deletions apps/web/src/app/(app)/code-reviews/ReviewAgentPageClient.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,12 +28,14 @@ type ReviewAgentPageClientProps = {
successMessage?: string;
errorMessage?: string;
initialPlatform?: Platform;
localCodeReviewDevelopmentEnabled?: boolean;
};

export function ReviewAgentPageClient({
successMessage,
errorMessage,
initialPlatform = 'github',
localCodeReviewDevelopmentEnabled = false,
}: ReviewAgentPageClientProps) {
const trpc = useTRPC();
const router = useRouter();
Expand Down Expand Up @@ -66,6 +68,8 @@ export function ReviewAgentPageClient({
const isGitHubAppInstalled =
githubStatusData?.connected && githubStatusData?.integration?.isValid;
const isGitLabConnected = gitlabStatusData?.connected && gitlabStatusData?.integration?.isValid;
const canUseGitHubJobs = isGitHubAppInstalled || localCodeReviewDevelopmentEnabled;
const canUseGitLabJobs = isGitLabConnected || localCodeReviewDevelopmentEnabled;

// Show toast messages from URL params
useEffect(() => {
Expand Down Expand Up @@ -139,7 +143,7 @@ export function ReviewAgentPageClient({
{/* GitHub Tab Content */}
<TabsContent value="github" className="mt-6 space-y-6">
{/* GitHub App Required Alert */}
{!isGitHubAppInstalled && (
{!isGitHubAppInstalled && !localCodeReviewDevelopmentEnabled && (
<Alert>
<Rocket className="h-4 w-4" />
<AlertTitle>GitHub App Required</AlertTitle>
Expand Down Expand Up @@ -172,7 +176,7 @@ export function ReviewAgentPageClient({
<TabsTrigger
value="jobs"
className="flex items-center gap-2"
disabled={!isGitHubAppInstalled}
disabled={!canUseGitHubJobs}
>
<ListChecks className="h-4 w-4" />
Jobs
Expand All @@ -192,8 +196,13 @@ export function ReviewAgentPageClient({
</TabsContent>

<TabsContent value="jobs" className="mt-6 space-y-4">
{isGitHubAppInstalled ? (
<CodeReviewJobsCard platform="github" />
{canUseGitHubJobs ? (
<CodeReviewJobsCard
platform="github"
localCodeReviewDevelopmentEnabled={localCodeReviewDevelopmentEnabled}
defaultModelSlug={selectedConfigData?.modelSlug}
defaultThinkingEffort={selectedConfigData?.thinkingEffort}
/>
) : (
<Alert>
<ListChecks className="h-4 w-4" />
Expand Down Expand Up @@ -225,7 +234,7 @@ export function ReviewAgentPageClient({
{/* GitLab Tab Content */}
<TabsContent value="gitlab" className="mt-6 space-y-6">
{/* GitLab Connection Required Alert */}
{!isGitLabConnected && (
{!isGitLabConnected && !localCodeReviewDevelopmentEnabled && (
<Alert>
<Rocket className="h-4 w-4" />
<AlertTitle>GitLab Connection Required</AlertTitle>
Expand Down Expand Up @@ -258,7 +267,7 @@ export function ReviewAgentPageClient({
<TabsTrigger
value="jobs"
className="flex items-center gap-2"
disabled={!isGitLabConnected}
disabled={!canUseGitLabJobs}
>
<ListChecks className="h-4 w-4" />
Jobs
Expand Down Expand Up @@ -286,8 +295,13 @@ export function ReviewAgentPageClient({
</TabsContent>

<TabsContent value="jobs" className="mt-6 space-y-4">
{isGitLabConnected ? (
<CodeReviewJobsCard platform="gitlab" />
{canUseGitLabJobs ? (
<CodeReviewJobsCard
platform="gitlab"
localCodeReviewDevelopmentEnabled={localCodeReviewDevelopmentEnabled}
defaultModelSlug={selectedConfigData?.modelSlug}
defaultThinkingEffort={selectedConfigData?.thinkingEffort}
/>
) : (
<Alert>
<ListChecks className="h-4 w-4" />
Expand Down
3 changes: 3 additions & 0 deletions apps/web/src/app/(app)/code-reviews/page.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
import { getUserFromAuthOrRedirect } from '@/lib/user/server';
import { isLocalCodeReviewDevelopmentEnabled } from '@/lib/config.server';
import { ReviewAgentPageClient } from './ReviewAgentPageClient';

type ReviewAgentPageProps = {
Expand All @@ -9,6 +10,7 @@ export default async function PersonalReviewAgentPage({ searchParams }: ReviewAg
const search = await searchParams;
const user = await getUserFromAuthOrRedirect('/users/sign_in?callbackPath=/code-reviews');
const platform = search.platform === 'gitlab' ? 'gitlab' : 'github';
const localCodeReviewDevelopmentEnabled = isLocalCodeReviewDevelopmentEnabled();

return (
<ReviewAgentPageClient
Expand All @@ -17,6 +19,7 @@ export default async function PersonalReviewAgentPage({ searchParams }: ReviewAg
successMessage={search.success}
errorMessage={search.error}
initialPlatform={platform}
localCodeReviewDevelopmentEnabled={localCodeReviewDevelopmentEnabled}
/>
);
}
32 changes: 24 additions & 8 deletions apps/web/src/app/(app)/organizations/[id]/code-reviews/ReviewAgentPageClient.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,6 +35,7 @@ type ReviewAgentPageClientProps = {
successMessage?: string;
errorMessage?: string;
initialPlatform?: Platform;
localCodeReviewDevelopmentEnabled?: boolean;
};

export function ReviewAgentPageClient({
Expand All @@ -43,6 +44,7 @@ export function ReviewAgentPageClient({
successMessage,
errorMessage,
initialPlatform = 'github',
localCodeReviewDevelopmentEnabled = false,
}: ReviewAgentPageClientProps) {
const trpc = useTRPC();
const router = useRouter();
Expand Down Expand Up @@ -84,6 +86,8 @@ export function ReviewAgentPageClient({
const isGitHubAppInstalled =
githubStatusData?.connected && githubStatusData?.integration?.isValid;
const isGitLabConnected = gitlabStatusData?.connected && gitlabStatusData?.integration?.isValid;
const canUseGitHubJobs = isGitHubAppInstalled || localCodeReviewDevelopmentEnabled;
const canUseGitLabJobs = isGitLabConnected || localCodeReviewDevelopmentEnabled;

// Show toast messages from URL params
useEffect(() => {
Expand Down Expand Up @@ -157,7 +161,7 @@ export function ReviewAgentPageClient({
{/* GitHub Tab Content */}
<TabsContent value="github" className="mt-6 space-y-6">
{/* GitHub App Required Alert */}
{!isGitHubAppInstalled && (
{!isGitHubAppInstalled && !localCodeReviewDevelopmentEnabled && (
<Alert>
<Rocket className="h-4 w-4" />
<AlertTitle>GitHub App Required</AlertTitle>
Expand Down Expand Up @@ -193,7 +197,7 @@ export function ReviewAgentPageClient({
<TabsTrigger
value="jobs"
className="flex items-center gap-2"
disabled={!isGitHubAppInstalled}
disabled={!canUseGitHubJobs}
>
<ListChecks className="h-4 w-4" />
Jobs
Expand All @@ -217,8 +221,14 @@ export function ReviewAgentPageClient({
</TabsContent>

<TabsContent value="jobs" className="mt-6 space-y-4">
{isGitHubAppInstalled ? (
<CodeReviewJobsCard organizationId={organizationId} platform="github" />
{canUseGitHubJobs ? (
<CodeReviewJobsCard
organizationId={organizationId}
platform="github"
localCodeReviewDevelopmentEnabled={localCodeReviewDevelopmentEnabled}
defaultModelSlug={selectedConfigData?.modelSlug}
defaultThinkingEffort={selectedConfigData?.thinkingEffort}
/>
) : (
<Alert>
<ListChecks className="h-4 w-4" />
Expand Down Expand Up @@ -254,7 +264,7 @@ export function ReviewAgentPageClient({
{/* GitLab Tab Content */}
<TabsContent value="gitlab" className="mt-6 space-y-6">
{/* GitLab Connection Required Alert */}
{!isGitLabConnected && (
{!isGitLabConnected && !localCodeReviewDevelopmentEnabled && (
<Alert>
<Rocket className="h-4 w-4" />
<AlertTitle>GitLab Connection Required</AlertTitle>
Expand Down Expand Up @@ -290,7 +300,7 @@ export function ReviewAgentPageClient({
<TabsTrigger
value="jobs"
className="flex items-center gap-2"
disabled={!isGitLabConnected}
disabled={!canUseGitLabJobs}
>
<ListChecks className="h-4 w-4" />
Jobs
Expand Down Expand Up @@ -323,8 +333,14 @@ export function ReviewAgentPageClient({
</TabsContent>

<TabsContent value="jobs" className="mt-6 space-y-4">
{isGitLabConnected ? (
<CodeReviewJobsCard organizationId={organizationId} platform="gitlab" />
{canUseGitLabJobs ? (
<CodeReviewJobsCard
organizationId={organizationId}
platform="gitlab"
localCodeReviewDevelopmentEnabled={localCodeReviewDevelopmentEnabled}
defaultModelSlug={selectedConfigData?.modelSlug}
defaultThinkingEffort={selectedConfigData?.thinkingEffort}
/>
) : (
<Alert>
<ListChecks className="h-4 w-4" />
Expand Down
3 changes: 3 additions & 0 deletions apps/web/src/app/(app)/organizations/[id]/code-reviews/page.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
import { OrganizationByPageLayout } from '@/components/organizations/OrganizationByPageLayout';
import { isLocalCodeReviewDevelopmentEnabled } from '@/lib/config.server';
import { ReviewAgentPageClient } from './ReviewAgentPageClient';

type ReviewAgentPageProps = {
Expand All @@ -9,6 +10,7 @@ type ReviewAgentPageProps = {
export default async function ReviewAgentPage({ params, searchParams }: ReviewAgentPageProps) {
const search = await searchParams;
const platform = search.platform === 'gitlab' ? 'gitlab' : 'github';
const localCodeReviewDevelopmentEnabled = isLocalCodeReviewDevelopmentEnabled();

return (
<OrganizationByPageLayout
Expand All @@ -20,6 +22,7 @@ export default async function ReviewAgentPage({ params, searchParams }: ReviewAg
successMessage={search.success}
errorMessage={search.error}
initialPlatform={platform}
localCodeReviewDevelopmentEnabled={localCodeReviewDevelopmentEnabled}
/>
)}
/>
Expand Down
1 change: 1 addition & 0 deletions apps/web/src/app/api/internal/code-review-status/[reviewId]/route.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -249,6 +249,7 @@ function makeReview(overrides: Partial<CloudAgentCodeReview> = {}): CloudAgentCo
repository_review_instructions_truncated: false,
previous_summary_body: null,
previous_summary_head_sha: null,
manual_config: null,
model: null,
total_tokens_in: null,
total_tokens_out: null,
Expand Down
19 changes: 14 additions & 5 deletions apps/web/src/app/api/internal/code-review-status/[reviewId]/route.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -92,6 +92,10 @@ import {
import type { Owner } from '@/lib/code-reviews/core';
import { parseCodeReviewAnalyticsManifest } from '@/lib/code-reviews/analytics/contracts';
import { finalizeCompletedCodeReviewWithAnalytics } from '@/lib/code-reviews/analytics/db';
import {
getManualCodeReviewConfig,
shouldPublishCodeReviewToProvider,
} from '@/lib/code-reviews/manual-config';

const CallbackTextTruncationSchema = z
.object({
Expand Down Expand Up @@ -1012,6 +1016,10 @@ export async function POST(
return NextResponse.json({ error: 'Review not found' }, { status: 404 });
}

const manualConfig = getManualCodeReviewConfig(review);
const isManualReview = manualConfig !== null;
const shouldPublishToProvider = shouldPublishCodeReviewToProvider(review);

const callbackCompletedAt = new Date();
let attempt: CloudAgentCodeReviewAttempt;
let latestAttempt = await getLatestCodeReviewAttempt(reviewId);
Expand Down Expand Up @@ -1332,7 +1340,7 @@ export async function POST(
let providerTerminalReason = terminalReason;
const actionRequiredReason =
status === 'failed' ? getActionRequiredTerminalReason(terminalReason, errorMessage) : null;
if (actionRequiredReason) {
if (actionRequiredReason && !isManualReview) {
const ownerResolution = await getTerminalOwnerResolution();
if (ownerResolution) {
try {
Expand All @@ -1354,7 +1362,7 @@ export async function POST(
});
}
}
} else if (status === 'failed') {
} else if (status === 'failed' && !isManualReview) {
const ownerResolution = await getTerminalOwnerResolution();
if (ownerResolution) {
try {
Expand All @@ -1381,9 +1389,10 @@ export async function POST(
}

// Fetch integration once — used for gate check updates and post-completion actions
const integration = review.platform_integration_id
? await getIntegrationById(review.platform_integration_id)
: null;
const integration =
shouldPublishToProvider && review.platform_integration_id
? await getIntegrationById(review.platform_integration_id)
: null;

// Resolve GitLab token once, shared between gate check and reaction/footer logic
const isGitLab = (review.platform || 'github') === PLATFORM.GITLAB;
Expand Down
Loading
Loading