Skip to content

Make sure kilt$getStepHeight runs overridden getStepHeight. #18

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
BluSpring merged 2 commits into from
Jun 13, 2026
Merged

Make sure kilt$getStepHeight runs overridden getStepHeight. #18

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d3d03f0
Make sure `kilt$getStepHeight` runs overridden `getStepHeight`.
Acuadragon100 Jun 13, 2026
8d58fe8
Rename
Acuadragon100 Jun 13, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions src/main/java/net/minecraftforge/common/extensions/IForgeEntity.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,7 @@
import net.minecraftforge.fluids.FluidType;
import org.jetbrains.annotations.Nullable;
import xyz.bluspring.kilt.injections.world.entity.EntityInjection;
import xyz.bluspring.kilt.util.KiltHelper;

import java.util.Collection;
import java.util.function.BiPredicate;
Expand Down Expand Up @@ -233,9 +234,19 @@ default float getStepHeight()
return this.kilt$getStepHeight(() -> self().maxUpStep());
}

ThreadLocal<Boolean> kilt$isCheckingHeight = ThreadLocal.withInitial(() -> false);

// Kilt: Custom provider to allow compat with other mods :D
default float kilt$getStepHeight(Supplier<Float> vanillaStepProvider)
{
if (KiltHelper.INSTANCE.hasMethodOverride(this.getClass(), IForgeEntity.class, "getStepHeight") && !kilt$isCheckingHeight.get()) {
try {
kilt$isCheckingHeight.set(true);
return getStepHeight();
} finally {
kilt$isCheckingHeight.set(false);
}
}
float vanillaStep = vanillaStepProvider.get();
if (self() instanceof LivingEntity living)
{
Expand Down