Skip to content

Conversation

@1isten
Copy link
Contributor

@1isten 1isten commented Jan 10, 2026

The segmentGroupStore.updateSegment function some how makes the metadata.segments.byValue.color field a proxy array.

Steps to reproduce: click the [Lock] or [Hide] toggle button, which calls the updateSegment function:
image

then, this object becomes proxied:

image

This leads to errors in below scenarios:

  1. Failed to create new segment group, which calls the structuredClone
image image
  1. Failed to save session, which calls the postMessage
image image

@netlify
Copy link

netlify bot commented Jan 10, 2026

Deploy Preview for volview-dev ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 5bdfa3c
🔍 Latest deploy log https://app.netlify.com/projects/volview-dev/deploys/696258e2cc64ed0008732c83
😎 Deploy Preview https://deploy-preview-839--volview-dev.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@PaulHax
Copy link
Collaborator

PaulHax commented Jan 12, 2026

Nice find. Thank you again.

@PaulHax PaulHax added this pull request to the merge queue Jan 12, 2026
Merged via the queue into Kitware:main with commit 2132fb4 Jan 12, 2026
7 of 9 checks passed
@1isten 1isten deleted the fix/update-segment branch January 13, 2026 00:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants