Conversation
|
The failure on CS is fixed in another PR #503 |
.github/workflows/build.yaml
Outdated
| symfony: ^8.0 | ||
| - description: 'Dev deps' | ||
| php: '8.5' | ||
| symfony: ^8.1 |
There was a problem hiding this comment.
the job with dev deps should not specify an override of the symfony version range.
There was a problem hiding this comment.
So it's going to take 8.1 anyway just because it's the latest dev, right?
There was a problem hiding this comment.
yes.
But it will take a newer dev version once available and compatible with our requirements, without the need to remember to update the CI config. Anytime we override the symfony requirement in the CI job, the composer.json is not the single source of truth anymore. This is why we override it only for jobs dedicated at testing compat with Symfony LTS versions (which is the explicit goal of those jobs, and requires maintenance only every 2 years)
.github/workflows/build.yaml
Outdated
| dev: true | ||
| - description: 'Dev deps' | ||
| symfony: ^7.4 | ||
| - description: 'Symfony 8' |
There was a problem hiding this comment.
I would remove this job. We need jobs for specific Symfony versions only for the LTS versions
There was a problem hiding this comment.
But 7.4 is an LTS version, isn't it?
There was a problem hiding this comment.
my comment is on the line defining a Symfony 8 job, not on the line defining a job for 7.4
2 participants
No description provided.