Use ArrayOfVectorViews as state variables instead of Dict#66
Open
Use ArrayOfVectorViews as state variables instead of Dict#66
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #66 +/- ##
==========================================
+ Coverage 96.82% 96.92% +0.10%
==========================================
Files 30 30
Lines 1166 1204 +38
==========================================
+ Hits 1129 1167 +38
Misses 37 37 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Avoids having
Dict{Int, Vector{ST}}whereSTis the type of the per-quadrature point state. This provides two main advantagesCurrent solutions stores an index vector (
Vector{Int}) which is used to translatecellnrtoidxinstate::ArrayOfVectorViews. This index vector could be the same for all domains as storage improvement, but currently isn't (just zero where not applicable). Also, the current implementation first creates theDicts, and then converts. But that is also just during construction and can be optimized later.Main downside is that when a user constructs a
Vector{ST}for their cell state, they will get a view instead (and possibly in the future into a different container for GPU support). So the user has to usestate::AbstractVector{ST}instead ofstate::Vector{ST}.