testdata: make the module zip-safe (build the apostrophe tree at test runtime) - #39
Merged
Conversation
The committed fixture path (AF01 - Shade's First Rule/Shade's First Rule.m4b) contains apostrophes, which golang.org/x/mod/zip prohibits in module zip file paths - so every version of this module was unfetchable by consumers (proxy or GOPROXY=direct alike), forcing dependents like audiosilo-manager and audiosilo-sidecars onto local replace directives. The apostrophes were incidental to the test (embedded-chapter expansion is the point), but they ARE worth exercising: the fixture moves to the zip-safe testdata/chaptered.m4b and the test now rebuilds the original apostrophe'd tree in a temp dir at runtime, keeping the coverage while making the module fetchable.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The committed folder-book fixture path contains apostrophes, which
golang.org/x/mod/zipprohibits - so every version of this module was unfetchable by consumers (verified:zip.CreateFromDirfails withinvalid char '\''), forcing dependents (audiosilo-manager, now audiosilo-sidecars forpkg/match) onto local replace directives.The fixture moves to zip-safe
testdata/chaptered.m4b; the test rebuilds the original apostrophe'd tree in a temp dir at runtime, so apostrophe-path scanning stays exercised. Verified locally: module zip creation now succeeds; full gate green.