Skip to content

add hostPrefix#90

Open
KamranBiglari wants to merge 2 commits into
Kong:mainfrom
KamranBiglari:patch-1
Open

add hostPrefix#90
KamranBiglari wants to merge 2 commits into
Kong:mainfrom
KamranBiglari:patch-1

Conversation

@KamranBiglari
Copy link
Copy Markdown

No description provided.

@CLAassistant
Copy link
Copy Markdown

CLAassistant commented Sep 29, 2023

CLA assistant check
All committers have signed the CLA.

@KamranBiglari KamranBiglari mentioned this pull request Sep 29, 2023
@KamranBiglari
Copy link
Copy Markdown
Author

#57

Copy link
Copy Markdown
Member

@windmgc windmgc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code LGTM, could you add some simple test case and a changelog entry?

Comment thread src/resty/aws/init.lua Outdated
@KamranBiglari
Copy link
Copy Markdown
Author

@windmgc Thank you for you changes. Where should I put changelog ?

This is required to SFN since startSyncExecution has hostPrefix which is different that sfn endpoint.

local AWS = require("resty.aws")
local aws = AWS()
local sfn = aws:SFN { region = "us-east-2" }
local results, err = sf:startSyncExecution  {
    stateMachineArn = ""
    input = cjson.encode( {} )
}

@Tieske
Copy link
Copy Markdown
Contributor

Tieske commented Oct 18, 2024

Thank you for you changes. Where should I put changelog ?

It's in the README, just add to the "unreleased" item at the top of the changelist (if there is none, then add one)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants