Open
Conversation
AlexandraOreza
approved these changes
May 9, 2023
AlexandraOreza
left a comment
AlexandraOreza
left a comment
There was a problem hiding this comment.
there's a console.log in Nav.tsx that should be deleted (or at least log something more useful than "hola")
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What's the new feature?
Use of an external library such as [next-themes] that facilitates the implementation, in such a way that it is only necessary to implement the logic to change the color in each component, through the context.
The theme can be changed via a button.
Does this new feature introduce a breaking change? If yes, explain it.
Yes, adds next-themes to manage the app theme (light/dark).
Reviewers
@MaddozS
@AlexandraOreza