Generate lexicographically ordered IDs for writeGeojson features #1640
Conversation
| simplePointsGeoDf.writeGeoJson(tempFile) | ||
|
|
||
| assertEquals(simplePointsGeoDf, GeoDataFrame.readGeoJson(tempFile.toURI().toURL())) | ||
| val loadedGeoDataFrame = GeoDataFrame.readGeoJson(tempFile.toURI().toURL()) |
There was a problem hiding this comment.
We need to add more IO overloads ;)
| assertEquals(simplePointsGeoDf, GeoDataFrame.readGeoJson(tempFile.toURI().toURL())) | ||
| val loadedGeoDataFrame = GeoDataFrame.readGeoJson(tempFile.toURI().toURL()) | ||
| assertEquals(simplePointsGeoDf.df, loadedGeoDataFrame.df) | ||
| // TODO: Doesn't work because of how equality between CRS is checked by geotools |
There was a problem hiding this comment.
The proper way to check CRS equality in Geotools is
CRS.equals, or CRS.equalsIgnoreMetadata if you don't want to compare metedata.
But there, shouldn't they be equal?
There was a problem hiding this comment.
It doesn't help :(
println(CRS.equalsIgnoreMetadata(simplePointsGeoDf.crs, loadedGeoDataFrame.crs))
false
They are in fact identical, two lines just go in different order
There was a problem hiding this comment.
Wait, then there's problem here! In GeoDataFrame (as in GeoJson specification) longitude should always go first! That's important!
There was a problem hiding this comment.
Interesting. This is how CRS looks right after reading of features:
Order of longitude is broken?
Content of the file we're reading from:
"crs":{"type":"name","properties":{"name":"EPSG:4326"}}
I see that our default CRS is created with longitudeFirst = true: CRS.decode("EPSG:4326", true)
...eo/src/main/kotlin/org/jetbrains/kotlinx/dataframe/geo/geotools/toSimpleFeatureCollection.kt
Show resolved
Hide resolved
...eo/src/main/kotlin/org/jetbrains/kotlinx/dataframe/geo/geotools/toSimpleFeatureCollection.kt
Show resolved
Hide resolved
2 participants
fixes #1565