[Communication] Move BaseSocketCommunication destructor to header to fix C++20 compilation#375
Closed
loumalouomega wants to merge 1 commit intomasterfrom
Closed
[Communication] Move BaseSocketCommunication destructor to header to fix C++20 compilation#375loumalouomega wants to merge 1 commit intomasterfrom
BaseSocketCommunication destructor to header to fix C++20 compilation#375loumalouomega wants to merge 1 commit intomasterfrom
Conversation
…o fix C++20 compilation
philbucher
approved these changes
Oct 29, 2025
matekelemen
requested changes
Oct 29, 2025
Contributor
|
The main issue is that I started an update to CoSim but didn't have time to finish it yet. Check these WIP pull requests: |
Member
Author
Ah, OK, sorry for the noise |
Member
Author
|
Are you sure this is fixed? https://github.com/KratosMultiphysics/Kratos/actions/runs/18912407359/job/53987835109, or do we need to do something in Kratos side? |
Member
Author
|
Ah, Okay, is hardcopied, it is not a subdmoule. My bad. |
Contributor
|
I'd be all for submodules but your boss vehemently opposes the idea. None of Kratos' dependencies are submodules. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📝 Description
Move
BaseSocketCommunicationdestructor to header to fix C++20 compilation. See for example: https://github.com/KratosMultiphysics/Kratos/actions/runs/18677406599/job/53257969885?pr=13549🆕 Changelog
BaseSocketCommunicationdestructor to header to fix C++20 compilation