Conversation
…tests-and-docs-for-stiffness-calculator
markelov208
previously approved these changes
Feb 4, 2026
Contributor
markelov208
left a comment
markelov208
left a comment
There was a problem hiding this comment.
Hi Richard, thank you for the updating the doc and adding stand-alone tests. I have two non-blocking comments.
...ation/tests/cpp_tests/custom_elements/contribution_calculators/test_stiffness_calculator.cpp
Outdated
Show resolved
Hide resolved
...ation/tests/cpp_tests/custom_elements/contribution_calculators/test_stiffness_calculator.cpp
Outdated
Show resolved
Hide resolved
…tests-and-docs-for-stiffness-calculator
rfaasse
commented
Feb 4, 2026
Contributor
Author
rfaasse
left a comment
rfaasse
left a comment
There was a problem hiding this comment.
Thank you for the review @markelov208! I have processed/answered both comments, let me know what you think!
...ation/tests/cpp_tests/custom_elements/contribution_calculators/test_stiffness_calculator.cpp
Outdated
Show resolved
Hide resolved
...ation/tests/cpp_tests/custom_elements/contribution_calculators/test_stiffness_calculator.cpp
Outdated
Show resolved
Hide resolved
…tests-and-docs-for-stiffness-calculator
…tests-and-docs-for-stiffness-calculator
WPK4FEM
previously approved these changes
Feb 5, 2026
Contributor
WPK4FEM
left a comment
WPK4FEM
left a comment
There was a problem hiding this comment.
Dear Richard,
Thank you for adding documentation and unit tests.
I have some insignificant comments and leave it to your judgement what to do with them.
Regards, Wijtze Pieter
...ns/GeoMechanicsApplication/custom_elements/contribution_calculators/stiffness_calculator.hpp
Outdated
Show resolved
Hide resolved
...ation/tests/cpp_tests/custom_elements/contribution_calculators/test_stiffness_calculator.cpp
Outdated
Show resolved
Hide resolved
...ation/tests/cpp_tests/custom_elements/contribution_calculators/test_stiffness_calculator.cpp
Show resolved
Hide resolved
...ation/tests/cpp_tests/custom_elements/contribution_calculators/test_stiffness_calculator.cpp
Show resolved
Hide resolved
...ation/tests/cpp_tests/custom_elements/contribution_calculators/test_stiffness_calculator.cpp
Outdated
Show resolved
Hide resolved
...ation/tests/cpp_tests/custom_elements/contribution_calculators/test_stiffness_calculator.cpp
Outdated
Show resolved
Hide resolved
markelov208
previously approved these changes
Feb 5, 2026
Contributor
markelov208
left a comment
markelov208
left a comment
There was a problem hiding this comment.
Hi Richard, thank you very much for processing the comments. I think the PR is ready to be merged.
rfaasse
commented
Feb 5, 2026
Contributor
Author
rfaasse
left a comment
rfaasse
left a comment
There was a problem hiding this comment.
Thank you both for the review, I think I processed them all now!
...ation/tests/cpp_tests/custom_elements/contribution_calculators/test_stiffness_calculator.cpp
Outdated
Show resolved
Hide resolved
...ation/tests/cpp_tests/custom_elements/contribution_calculators/test_stiffness_calculator.cpp
Show resolved
Hide resolved
...ation/tests/cpp_tests/custom_elements/contribution_calculators/test_stiffness_calculator.cpp
Outdated
Show resolved
Hide resolved
...ation/tests/cpp_tests/custom_elements/contribution_calculators/test_stiffness_calculator.cpp
Show resolved
Hide resolved
WPK4FEM
approved these changes
Feb 5, 2026
rfaasse
deleted the
geo/14017-add-unit-tests-and-docs-for-stiffness-calculator
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📝 Description
The stiffness calculator was only tested via the unit tests of the interface elements. Explicit unit tests, as well as documentation is added in this PR.
🆕 Changelog