[OptApp] Fixing the nodal value to condition / element container mapping (inverse as well)#14174
Open
sunethwarna wants to merge 1 commit intomasterfrom
Open
[OptApp] Fixing the nodal value to condition / element container mapping (inverse as well)#14174sunethwarna wants to merge 1 commit intomasterfrom
sunethwarna wants to merge 1 commit intomasterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📝 Description
There is a bug in nodal value to condition / element mapping (reverse as well). Previously when condition / element values are mapped to nodal values, the condition / element value is devided by number of neighbour conditions / elements around each node and this was added to the node. Now it is corrected to divide by number of nodes in the geometry. Proper tests are also added to check for the global consistency.
Unfortunately, this requires change in the reference values of filter tests.
@Igarizza I had to change control field update to
0.001to trigger it be active, could you take a close look (intest_relaxed_gradient_projection.py)🆕 Changelog