[Core] Hotfix for geometries_tensor_adaptor#14182
Open
RiccardoRossi wants to merge 1 commit intomasterfrom
Open
[Core] Hotfix for geometries_tensor_adaptor#14182RiccardoRossi wants to merge 1 commit intomasterfrom
geometries_tensor_adaptor#14182RiccardoRossi wants to merge 1 commit intomasterfrom
Conversation
Member
It could be more specific... |
geometries_tensor_adaptor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📝 Description
The manual calculation of Cartesian shape function derivatives (computing local gradients, calculating the Jacobian, inverting it, and performing matrix multiplication) has been replaced by a direct call to the geometry's gradient method. This removes significant boilerplate and leverages the internal optimizations of the
Geometryclass.Key Changes
CollectShapeFunctionsDerivativesto fetch the required gradients (presumably Cartesian, depending on theMethodpassed) directly into theDN_Dxcontainer.pDatamore direct and readable.Impact
🆕 Changelog
geometries_tensor_adaptor