Claude/game module engines editors 5y us9#354
Merged
Conversation
The SparkGameEngineEditor module duplicated 6 of 9 subsystems that already exist in the engine/editor (Material 95%, Animation 90%, Level Design 85%, VFX 80%, Asset Pipeline 75%, Visual Scripting 40%). Moved the 2 truly unique subsystems into SparkEditor as proper panels: - Prototyping: blockout primitives, 8 game templates, gameplay rules, play-test sessions (SparkEditor/Source/Prototyping/) - UI Designer: WYSIWYG widget tree editor with anchors, data binding, style system, 3 presets (SparkEditor/Source/UIDesigner/) Both registered in EditorPanelFactory with icons and default visibility. Deleted the entire GameModules/SparkGameEngineEditor/ directory. https://claude.ai/code/session_01D2R4yPRwqonR24XjxUziy1
Compiler fixes (VisualScriptCompiler.cpp): - Branch: proper if/else with true/false path routing - ForLoop: generates real for-loop with start/end/index - PlaySound/PlayAnimation: emit real API calls instead of print() - DestroyEntity/SetHealth: emit real calls instead of comments - FireEvent: emit real fireEvent() call - GetVariable: emits actual variable reference as typed output - SetVariable: fixed input index - Added missing: GetPosition, GetRotation, GetHealth, GetSpeed, GetEntityByName, SetPosition, SetRotation, ApplyForce, Normalize, DotProduct, Distance, Sequence - New node types: DefineCustomEvent, CallFunction, ReturnValue - Function sub-graphs compile to separate class methods - Custom event definitions compile to handler methods Editor fixes (VisualScriptPanel.cpp): - Pin-to-pin connection dragging with bezier preview - Type compatibility validation (Exec<>Exec, Float<>Int, etc.) - Hover highlight on pins, cancel with right-click/Escape - Single-connection-per-input enforcement - Graph save/load to .vscript JSON files - Save/Load buttons in compile toolbar - Complete pin definitions for all 50 node types - New Functions category in palette (Custom Event, Call, Return) New ScriptDebugPanel: - Breakpoint management with enable/disable and hit counts - Variable watch panel with live value display - Execution trace log with timestamps - Debug compile mode (instruments scripts with trace calls) - Pause/resume execution on breakpoint hits https://claude.ai/code/session_01D2R4yPRwqonR24XjxUziy1
AngelScript API bindings (AngelScriptEngine.cpp): - Added 14 new global functions callable from generated scripts: destroyEntity, getPosition, setPosition, getRotation, setRotation, getHealth, setHealth, getSpeed, applyForce, playSound, playAnimation, getEntityByName, fireEvent, debugTrace - All registered in RegisterGlobalFunctions() with proper AS signatures - Entity functions use World/ECS (Transform, HealthComponent, NameComponent) Compiler improvements (VisualScriptCompiler.cpp): - ForLoop now emits connected body nodes inside the loop block - Branch walks full execution chain per path (not just first node) - Debug trace mode: when enabled, inserts debugTrace() call before each node - Compile() now accepts debugMode parameter Editor improvements (VisualScriptPanel.cpp): - CompileGraph() now calls AngelScriptEngine::CompileScriptFromString() to load generated scripts into the runtime (scripts actually execute) - Generated code preview (collapsible) in compile toolbar - LoadGraph() fully implemented with JSON parsing (nodes, connections, variables restored from .vscript files) - Key name dropdown (24 keys) for OnKeyPress/GetKeyDown/GetKey nodes - Property editors for PlaySound, PlayAnimation, FireEvent, SpawnEntity, GetEntityByName, CallFunction, Get/SetVariable with variable dropdown - Variable dropdown for Get/Set Variable nodes shows declared variables https://claude.ai/code/session_01D2R4yPRwqonR24XjxUziy1
…afety Compiler fixes (VisualScriptCompiler.cpp): - Fixed action node input indices: all action nodes (SetPosition, SetHealth, ApplyForce, DestroyEntity, PrintMessage, SetVariable) now correctly skip input[0] (Exec pin) and read data from input[1+] - ForLoop uses correct indices: Start=input[1], End=input[2], Index=out[1] - GetDeltaTime emits `float n_out0 = dt;` instead of comment - Sequence emits connected nodes for each output pin in order - Added selfEntity member variable to generated class - Double-emission prevention: nodes that are children of Branch/ForLoop/ Sequence are collected and skipped from the main emission loop Editor fixes (VisualScriptPanel.cpp): - Execution pin type safety: Exec pins can only connect to Exec pins, data pins cannot connect to Exec pins - SaveGraph now serializes node properties (key, sound, animation, event, function names) and constant default values to JSON - Int<>Float implicit conversion still allowed for data pins https://claude.ai/code/session_01D2R4yPRwqonR24XjxUziy1
Compiler fixes: - Branch condition now correctly reads input[1] (was input[0] = Exec pin) - Execution chain walker uses pin kind check instead of broken double-negation - Removed dead for-loop on trueChain variable Editor UX improvements: - Pin labels shown on all nodes (type name for data pins, True/False for Branch, Body/Done for ForLoop, 0/1/2 for Sequence) - Node palette search filter with case-insensitive matching, auto-opens matching categories - Comment nodes (green, no pins, editable text body rendered on canvas) - Debug compile checkbox in toolbar with tooltip - LoadGraph now parses and restores node properties (key names, sound names, etc.) using brace-depth-aware JSON parser Debug system wired end-to-end: - ASDebugTrace() calls through DebugTraceCallback to ScriptDebugPanel - ScriptDebugPanel registers callback on Initialize() - Trace entries flow from running scripts -> engine -> editor panel - Breakpoint hit detection triggers pause in debug panel https://claude.ai/code/session_01D2R4yPRwqonR24XjxUziy1
Undo/Redo for graph edits (VisualScriptPanel): - AddNodeCommand, RemoveNodeCommand, AddConnectionCommand with full undo support (snapshot/restore node state and connections) - Direct operation methods for commands to call without undo tracking - UndoRedoManager integration point via SetUndoRedoManager() Step-through debugger (ScriptDebugPanel): - Step Over: execute one node then pause (m_stepMode flag) - Continue: resume until next breakpoint - Call Stack tab showing recent execution trace with current node - Paused-at-node indicator in toolbar - Step mode auto-pauses after receiving one trace entry SparkGameVisualScript — zero C++ game logic module: - ALL gameplay defined in 5 visual scripts (AngelScript .as files): * PlayerController: WASD movement, jump, sprint, health regen * Collectible: spinning coins with bob animation, score on pickup * EnemyPatrol: waypoint patrol, player detection, chase AI, attack * GameManager: score tracking, win condition (5 coins), game over * HealthPickup: healing on contact, respawn after 10s cooldown - C++ shell (Main.cpp) only loads scripts and spawns 11 entities - Game features: movement, collectibles, enemies, health, win/lose - Zero lines of C++ game logic — everything runs through AngelScript https://claude.ai/code/session_01D2R4yPRwqonR24XjxUziy1
Contributor
✅ CI Errors ResolvedAll previously reported errors have been fixed. All builds passing. Last checked: 2026-04-03T21:41:03Z |
- PinKind → Spark::Scripting::PinKind (fully qualified namespace) - ImVec2 m_canvasOrigin → float m_canvasOriginX/Y (no imgui.h in header) - ImVec2 GetPinScreenPos() → void GetPinScreenPos(float& outX, float& outY) - Updated all callers in RenderPendingConnection and HitTestPin https://claude.ai/code/session_01D2R4yPRwqonR24XjxUziy1
The coverage job (Code Coverage GCC) was missing error extraction and artifact upload on failure. When coverage failed, the CI Error Report had no data about it and silently reported "no errors". Added to the coverage job: - Build output captured to cmake-build.log via tee - Test output captured to test-output.log via tee - extract-errors.sh runs on failure to parse build/test errors - error-summary.json uploaded as ci-errors-coverage artifact - CI Error Report job already had coverage in its needs list Now when coverage fails, the consolidated error report will include the coverage job's build errors, test failures, and warnings. https://claude.ai/code/session_01D2R4yPRwqonR24XjxUziy1
Contributor
Code Coverage (GCC + lcov) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.