E2E suite router#628
Conversation
|
Warning Review limit reached
Next review available in: 13 minutes Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (4)
📝 WalkthroughWalkthroughChangesE2E smoke routing
Estimated code review effort: 3 (Moderate) | ~20 minutes Possibly related issues
Possibly related PRs
Suggested reviewers: Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
nice |
|
b0cf34f to
d05428e
Compare
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 4
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In @.github/workflows/e2e-common.yaml:
- Around line 78-83: Update the workflow step around SPEC_FILTER to receive the
input through the step’s env configuration, then reference the environment
variable in the shell rather than interpolating inputs.specs directly. Preserve
the existing conditional behavior and Playwright commands for empty and
non-empty filters.
In @.github/workflows/e2e.yaml:
- Around line 20-22: Update the actions/checkout@v4 step in the route job to set
persist-credentials to false, while retaining fetch-depth: 0 for git diff
access.
- Around line 15-29: Add an explicit permissions block to the route job,
granting only contents: read for checkout and repository diff access. Keep the
existing route steps, outputs, and token permissions otherwise unchanged.
In `@CLAUDE.md`:
- Line 247: Update the COMPONENT_MAP guidance in CLAUDE.md to match the bash
3.2-compatible implementation in build/suite-router.sh: replace
associative-array syntax with instructions and an example showing a new if/grep
-qE block that appends the relevant spec to SPECS, while preserving the
surrounding routing behavior and terminology.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: c9b080f4-9e54-4153-b3b2-694dbf34c840
📒 Files selected for processing (4)
.github/workflows/e2e-common.yaml.github/workflows/e2e.yamlCLAUDE.mdbuild/suite-router.sh
|
👀 |
jasonmadigan
left a comment
jasonmadigan
left a comment
There was a problem hiding this comment.
some small stuff, no biggies. would like to merge.
| - Gateway and policy management | ||
| - Topology visualization | ||
|
|
||
| ### E2E Test Tags |
| fi | ||
|
|
||
| if echo "$CHANGED" | grep -qE "^src/components/apiproduct/"; then | ||
| SPECS="$SPECS apiproduct-crud.spec.ts apiproduct-overview-tab.spec.ts api-product-list.spec.ts" |
There was a problem hiding this comment.
apiproduct-rbac.spec.ts missing?
| ``` | ||
|
|
||
| **Rules:** | ||
| - Every test must have exactly one tag (`@smoke` or `@nightly`) — untagged tests are skipped in both runs |
There was a problem hiding this comment.
untagged tests are skipped in both runs
iirc nightly runs npx playwright test with no grep (e2e-common.yaml:88), so untagged tests do run nightly.
Signed-off-by: Anton-Fil <a.filkach@gmail.com>
Signed-off-by: Anton-Fil <a.filkach@gmail.com>
Signed-off-by: Anton-Fil <a.filkach@gmail.com>
Signed-off-by: Anton-Fil <a.filkach@gmail.com>
…correct tag docs Signed-off-by: Anton-Fil <a.filkach@gmail.com>
22e3fb6 to
eb93cd3
Compare
3 participants
Description
Adds a changed-file inference suite router that maps source file changes to relevant e2e spec files. Instead of running all smoke tests on every PR (~11 min), the CI now detects which components changed and runs only the relevant spec files
Fixes #587
Type of change
[fix]Bug fix[feat]New feature[refactor]Refactor (no functional changes)[test]Test updates[chore]Dependency / config updateChanges made
build/suite-router.sh— bash script that maps changed source paths to relevant e2e spec files; outputs space-separated paths or empty string for full smoke fallbackroutejob toe2e.yamlthat runs the suite-router and passes its output to the smoke jobspecsinput toe2e-common.yaml— if non-empty, runs only the specified spec files with--grep @smoke; falls back to all smoke tests when emptyTest plan
build/suite-router.shlocally — correct spec files returned for apikey component changessrc/utils/and unknown pathsroutejob output in GitHub ActionsScreenshots
i crated test pr in fork for show how its work
Anton-Fil#5
Summary by CodeRabbit
Tests
Documentation