-
Notifications
You must be signed in to change notification settings - Fork 3
Fix Titanfall Online pkg file parsing/decrypting #2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
p0358
wants to merge
18
commits into
L-Leite:master
Choose a base branch
from
harmonytf:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Author
It seems that the checksums hardcoded into the tests were incorrect, the top checksum that the new build computed is equal to what I compute from my dumped files that were extracted with the original game engine itself. I'm updating the tests to correct that |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Everything seems to be okay now, but I didn't have an opportunity to test it with UnCSO2 GUI to ensure. Yes, basically all uint32 in the entry header needed to be changed to uint64 plus padding adjusted and it just works then xD Credits for header reversal to @mrsteyk
I also did a tiny change/test around decrypting small files