Open
Conversation
…directly instead of baseline in TECA_DATA_ROOT
elbashandy
force-pushed
the
cartesian_mesh_reader_regex
branch
from
89afd32 to
1a5cb87
Compare
burlen
reviewed
Nov 18, 2020
Collaborator
burlen
left a comment
burlen
left a comment
There was a problem hiding this comment.
a couple of changes to make here.
|
|
||
| fn = file_util.replace_timestep(baseline, check_step) | ||
| do_test = system_util.get_environment_variable_bool('TECA_DO_TEST', True) | ||
| if do_test and os.path.exists(fn): |
Collaborator
There was a problem hiding this comment.
don't remove the TECA_DO_TEST feature, which can be used to automatically regenerate baselines across all tests. it has been removed here and in other tests that were modified.
| variables_map &opts) | ||
| { | ||
| TECA_POPTS_SET(opts, std::string, prefix, file_name) | ||
| TECA_POPTS_SET(opts, std::string, prefix, files_regex) |
Collaborator
There was a problem hiding this comment.
We only need one of these options. Either file_name or files_regex.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #288
does not resolve 316