Update GitHub Actions to Node 24 runtime#7
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
actions/cache@v4toactions/cache@v5, which declares the Node 24 runtime.FORCE_JAVASCRIPT_ACTIONS_TO_NODE24: truesoilammy/msvc-dev-cmd@v1no longer runs under the deprecated Node 20 runtime.Verification
actions/cache@v5action metadata declaresusing: node24.ilammy/msvc-dev-cmd@v1/v1.13.0still declaresusing: node20, so the workflow-level Node 24 opt-in is required unless we replace that action..github/workflows/ci.ymland.github/workflows/release.ymlgit diff --check -- .github/workflows/ci.yml .github/workflows/release.ymlactions/cache@v5andFORCE_JAVASCRIPT_ACTIONS_TO_NODE24: trueNotes
This keeps the existing MSVC setup behavior unchanged. A larger alternative would be replacing
ilammy/msvc-dev-cmdwith an inline PowerShell/vswhere setup step, but that is higher risk for the Windows ARM job.