Skip to content

Generating SessionSigs Guide Code Implementation #15

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
Spacesai1or wants to merge 4 commits into from
Closed

Generating SessionSigs Guide Code Implementation #15

Spacesai1or wants to merge 4 commits into from

Conversation

@Spacesai1or
Copy link
Contributor

@Spacesai1or Spacesai1or commented May 31, 2024 •
edited
Loading

This is the corresponding PR for the guide rewrite

Pre-Merge Standard Guide Checklist

  • User story/motivation for the guide has been identified
  • User story/motivation is addressed by the guide
  • Prerequisite knowledge is noted at the beginning of the guide, with links to where to learn more if the user does not possess this knowledge
  • Example code has contains all code and components required for a basic user to run it without implicit knowledge of other code/tools that need to be incorporated
  • Example code runs without bugs
  • No pseudocode
  • Full written explanations of all steps required to use a given feature (alongside code)
  • Warnings for when code is only relevant to a given testnet/function/version/etc.
  • Documentation titles and categorization are clear for new users
  • Guide and example code has been reviewed, followed, and successfully run by a peer who has not already worked on the guide/code and is taking on the persona of a target user for the user story/motivation
  • Guide has been reviewed for correct spelling and grammar
  • Project Lead (or another knowledgeable party) for the feature has reviewed the guide/code and checked for accuracy/completeness
  • Final review and sign-off from Product Manager

@Spacesai1or Spacesai1or mentioned this pull request May 31, 2024
Open
joshLong145
joshLong145 reviewed Jun 2, 2024
View reviewed changes
get-session-sigs-via-auth-sig/nodejs/package.json
Comment on lines +12 to +14
"@lit-protocol/auth-helpers": "^6.0.0-beta.3",
"@lit-protocol/constants": "^6.0.0-beta.3",
"@lit-protocol/lit-node-client": "^6.0.0-beta.3",
Copy link

@joshLong145 joshLong145 Jun 2, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we update to beta.4

get-session-sigs-via-auth-sig/nodejs/src/index.ts
const ethersSigner = new ethers.Wallet(
ETHEREUM_PRIVATE_KEY,
new ethers.providers.JsonRpcProvider(
"https://chain-rpc.litprotocol.com/http"
Copy link

@joshLong145 joshLong145 Jun 2, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we switch this to our replica endpoints

@Spacesai1or Spacesai1or deleted the wyatt/get-session-sigs-via-auth-sig branch October 22, 2024 00:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@joshLong145 joshLong145 joshLong145 left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Spacesai1or @joshLong145