Some fixes (Fixes #41, Fixes #35) #44
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* fix: avoid view name collision with other plugins by renaming to csv-lite-view & csv-lite-source-view * chore: update comments to reflect csv-lite view name
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request introduces several improvements and refactors to the CSV Lite plugin, focusing on enhanced internationalization, better user notifications, and codebase consistency. The most significant changes include the addition of a GitHub Actions CI workflow, improved i18n support for user-facing messages, standardized view type naming, and enhanced undo/redo feedback. The update also includes minor styling fixes and version bumps.
Internationalization and User Notifications:
src/i18n/en.ts) and Chinese (src/i18n/zh-cn.ts). All user-facing notifications now use these i18n strings for consistency and localization. [1] [2] [3] [4] [5] [6] [7] [8] [9]View Type and Naming Consistency:
csv-view/csv-source-viewtocsv-lite-view/csv-lite-source-viewthroughout the codebase to standardize naming and avoid conflicts. [1] [2] [3] [4] [5] [6] [7] [8] [9]Continuous Integration:
.github/workflows/ci.yml) for automated CI, including dependency installation, code formatting checks, TypeScript build, and tests.Testing and Undo/Redo Improvements:
HistoryManagerto verify undo/redo notification messages using i18n. Improved undo/redo logic to show appropriate localized messages when actions are unavailable. [1] [2] [3]Styling and Miscellaneous:
styles.css). Updated plugin version numbers inmanifest.jsonandpackage.json. [1] [2] [3] [4]These changes collectively enhance the user experience, code maintainability, and plugin reliability.