Open
Conversation
krame505
approved these changes
Apr 23, 2018
Member
krame505
left a comment
krame505
left a comment
There was a problem hiding this comment.
Looks good, aside from some minor comments. Good to merge, assuming you made sure that this compiles.
| Serial.println(F("Thrust below critical level")); | ||
| abort_autosequence(); | ||
| } | ||
| // Check that the pressure of the fuel and oxidizer line have not exceeded the maximum limit |
Member
There was a problem hiding this comment.
Are you sure that we only want this check after ignition and mainstage? Seems like we might want to abort before ignition if the line pressures are too high. Unless those sensors are downstream of the valves, in which case ignore this comment.
Author
There was a problem hiding this comment.
Good catch. I'll double check that with Jame as I'm not positive
Contributor
There was a problem hiding this comment.
We do want to check pressures after the prestage valves have opened before ignition.
| // Check that the pressure of the fuel and oxidizer line have not exceeded the maximum limit | ||
| #if CONFIGURATION != DEMO | ||
| else if (run_time >= STARTUP_TIME && pressure_fuel > MAX_PRESSURE_FUEL) { | ||
| Serial.println(F("Fuel pressue above critical level")); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.