Slsim logo#433
Conversation
merged to main
updated with main
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #433 +/- ##
=======================================
Coverage 98.66% 98.66%
=======================================
Files 106 106
Lines 8320 8340 +20
=======================================
+ Hits 8209 8229 +20
Misses 111 111 🚀 New features to boost your workflow:
|
…slsim_logo merged to remote
sibirrer
left a comment
sibirrer
left a comment
There was a problem hiding this comment.
Thank you @nkhadka21! I made some suggestion to have the code base a bit smaller
sibirrer
left a comment
sibirrer
left a comment
There was a problem hiding this comment.
Thank you @nkhadka21 !
I have some comments and suggestions for the citation guidelines, but approve here already.
| If you use part of this package for your research, We strive for open-source and reproducible science and all of our code is open-source available here. | ||
| If you use part of this package for your research, please cite: | ||
| `Khadka et al. (2026) <https://ui.adsabs.harvard.edu/abs/2026arXiv260317138K/abstract>`_. | ||
| Additional SLSim publications may be released in the future, and these citation guidelines will |
There was a problem hiding this comment.
perhaps add that for the usage of individual modules, other citations may be required. I am thinking of SkyPy, SL_hammock and other things. Just that this is not a blank check to not cite other work the code relied on
| We strive for open-source and reproducible science and all of our code is open-source available here. | ||
| If you use part of this package for your research, please link to this repository. | ||
| We plan to have several publications an will revise these guidelines. No newline at end of file | ||
| If you use part of this package for your research, We strive for open-source and reproducible science and all of our code is open-source available here. |
There was a problem hiding this comment.
"We strive" -> "we strive"
2 participants
This PR adds: