parsing: allow .yml extension#97
Merged
liambrady merged 1 commit intoLabNConsulting:mainfrom Mar 20, 2026
Merged
Conversation
liambrady
requested changes
Mar 19, 2026
Contributor
liambrady
left a comment
There was a problem hiding this comment.
Thanks for the contribution. Please fix the following lint errors (from make ci-lint):
munet/parser.py:105:0: C0301: Line too long (89/88) (line-too-long)
munet/parser.py:115:9: R1714: Consider merging these comparisons with 'in' by using 'ext in ('yaml', 'yml')'. Use a set instead if elements are hashable. (consider-using-in)
Although not official recommended YAML extension, .yml extension may still be preferred by some users. This just creates an allowance for that.
8a9c60e to
e565ff6
Compare
Contributor
Author
|
@liambrady Hadn't seen the linting failure. Done the required changes and ammended them to the commit. It should be ready for review. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #97 +/- ##
==========================================
- Coverage 60.62% 60.48% -0.14%
==========================================
Files 19 19
Lines 5973 5988 +15
==========================================
+ Hits 3621 3622 +1
- Misses 2352 2366 +14 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Although not official recommended YAML extension, .yml extension may still be preferred by some users. This just creates an allowance for that.