Skip to content

parsing: allow .yml extension#97

Merged
liambrady merged 1 commit intoLabNConsulting:mainfrom
Paul-weqe:yml-extension
Mar 20, 2026
Merged

parsing: allow .yml extension#97
liambrady merged 1 commit intoLabNConsulting:mainfrom
Paul-weqe:yml-extension

Conversation

@Paul-weqe
Copy link
Contributor

Although not official recommended YAML extension, .yml extension may still be preferred by some users. This just creates an allowance for that.

Copy link
Contributor

@liambrady liambrady left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution. Please fix the following lint errors (from make ci-lint):

munet/parser.py:105:0: C0301: Line too long (89/88) (line-too-long)
munet/parser.py:115:9: R1714: Consider merging these comparisons with 'in' by using 'ext in ('yaml', 'yml')'. Use a set instead if elements are hashable. (consider-using-in)

Although not official recommended YAML extension, .yml extension may
still be preferred by some users. This just creates an allowance for
that.
@Paul-weqe
Copy link
Contributor Author

@liambrady Hadn't seen the linting failure.

Done the required changes and ammended them to the commit. It should be ready for review.

@codecov
Copy link

codecov bot commented Mar 20, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 60.48%. Comparing base (58e72ab) to head (e565ff6).
⚠️ Report is 9 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #97      +/-   ##
==========================================
- Coverage   60.62%   60.48%   -0.14%     
==========================================
  Files          19       19              
  Lines        5973     5988      +15     
==========================================
+ Hits         3621     3622       +1     
- Misses       2352     2366      +14     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Contributor

@liambrady liambrady left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@liambrady liambrady merged commit d30cc53 into LabNConsulting:main Mar 20, 2026
3 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants