Skip to content

fix: implement down in add-loan-events-missing-indexes to drop indexes #1290

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ogazboiz merged 2 commits into from
Jul 3, 2026
Merged

fix: implement down in add-loan-events-missing-indexes to drop indexes #1290

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1c10911
fix: implement down in add-loan-events-missing-indexes to drop indexes
Jun 29, 2026
28723d9
chore: add comment about shared index and remove stray md file
Jul 1, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 9 additions & 4 deletions backend/migrations/1788000000018_add-loan-events-missing-indexes.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,9 +35,14 @@ export const up = (pgm) => {
};

/**
* Keep rollback non-destructive because several indexes above may already
* exist from prior migrations with shared names.
*
* @param pgm {import('node-pg-migrate').MigrationBuilder}
* @returns {void}
*/
export const down = () => {};
export const down = (pgm) => {
pgm.sql(`DROP INDEX IF EXISTS idx_loan_events_created_at;`);
// Note: idx_loan_events_loan_id_event_type is also created by the earlier 1777 composite-indexes migration.
// A partial rollback of just 1788 would drop an index 1777 also owns, but IF EXISTS keeps it safe.
pgm.sql(`DROP INDEX IF EXISTS idx_loan_events_loan_id_event_type;`);
pgm.sql(`DROP INDEX IF EXISTS idx_loan_events_event_type;`);
pgm.sql(`DROP INDEX IF EXISTS idx_loan_events_borrower;`);
};
Loading