COPY and IGNORE_ERRORS with dups improvements#607
Merged
Conversation
adsharma
changed the title
adsharma
changed the title
Contributor
some test failed Test input syntax is outdated |
Contributor
as this case . When I use IGNORE_ERRORS=true, shouldn't it execute according to the original semantics? At the very least, it should give the user some information that there was an error, and how to check it. But it seems like that's not the case. I did a test (IGNORE_ERRORS=true (DUPLICATE_PK_ONLY)), and currently that feature works fine. My previous design intent for the feature was to avoid affecting the original functionality and capabilities, after all, this feature is just an optimization for some special insert scenarios.
|
Contributor
I try it with call show_warning. It will show it. So we just need add some waring log for user right?
|
adsharma
force-pushed
the
duplicate_pk_syntax_return
branch
from
292627b to
7057343
Compare
The new COPY option syntax IGNORE_ERRORS=true (DUPLICATE_PK_ONLY) replaces SKIP_DUPLICATE_PK=true, and the node COPY result contract is now consistently 1 row with 3 columns: - Column 0: the result message (with warning summary folded in when warnings exist, e.g. "5 tuples have been copied to the person table. 2 warnings encountered during copy. Use 'CALL show_warnings() RETURN *' to view the actual warnings. Query ID: 6") - Column 1: skipped_duplicate_pk_count (INT64) - Column 2: skipped_duplicate_pks (LIST<STRING>)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Address review comments from #601
@ericyuanhui could you please review/test this?