Fix segfault on label() of list element#608
Merged
Merged
Conversation
Contributor
Author
|
The failing test seems to be related to installation of the neo4j extension: |
Contributor
|
Thank you for the fixes! CI is sometimes flaky. Rerunning fixed it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes this segfault
And another one on comparisons like
ns[1] <> ns[0].Here is the original bug report kuzudb/kuzu#6050, addressed in Ryu with predictable-labs/ryugraph#2
Despite the claim in #184 , this was never ported to ladybug, hence this PR.
The problem is incorrect binding of non-pattern exprs in
label()and in comparisons. I added some new test cases for the latter.Another two fixes were missing from that PR. I'll prepare separate ones for them