add lance tables support#613
Draft
aheev wants to merge 1 commit into
Draft
Conversation
adsharma
reviewed
Jun 23, 2026
| namespace common { | ||
|
|
||
| enum class StorageFormat : uint8_t { NONE, ICEBUG_DISK }; | ||
| enum class StorageFormat : uint8_t { NONE, ICEBUG_DISK, LANCE }; |
Contributor
There was a problem hiding this comment.
Does the base need to know about LANCE? I'm concerned that isLance kind of negates the purpose of extensions.
Member
Author
There was a problem hiding this comment.
I don’t think it’s really possible to distinguish Lance from other tables without a catalog or namespace otherwise
Member
Author
There was a problem hiding this comment.
are you concerned about the mix tables check or the enum? The enum serves a similiar purpose as CatalogEntryType::FOREIGN_TABLE_ENTRY
Contributor
There was a problem hiding this comment.
Let's rename it to something generic instead of Lance. There are at least 5 table formats that want to replace parquet.
13 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.