Skip to content

standardize table storage and scans#614

Open
aheev wants to merge 4 commits into
LadybugDB:mainfrom
aheev:std-storage
Open

standardize table storage and scans#614
aheev wants to merge 4 commits into
LadybugDB:mainfrom
aheev:std-storage

Conversation

@aheev

@aheev aheev commented Jun 23, 2026

Copy link
Copy Markdown
Member
  • add createScanState
  • get rid of arrowTable::getNumBatches
  • rm arrow/icebug-disk dynamic_cast checks wherever possible

@aheev aheev marked this pull request as ready for review June 23, 2026 14:45
@aheev

aheev commented Jun 23, 2026

Copy link
Copy Markdown
Member Author

@adsharma could you PTAL?

@aheev

aheev commented Jun 23, 2026

Copy link
Copy Markdown
Member Author

failing test is unrelated:

EXPECT OK BUT GOT ERROR: IO exception: Failed to create directory /home/runner/.lbdb/extension/0.17.0/linux_amd64/ due to: IO exception: Directory /home/runner/.lbdb/extension/0.17.0/linux_amd64 cannot be created. Check if it exists and remove it.

@aheev

aheev commented Jun 23, 2026

Copy link
Copy Markdown
Member Author

This refactor has been carried out based on the assumption that any new external table formats will strictly conform to ColumnarTableBase. Otherwise common functions like getNumScanMorsels and createScanState would need to be moved to NodeTable / RelTable classes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant