[lua, sql] Mobskill Rework: Magical Skills #8360

UmeboshiXI · 2025-10-08T20:46:35Z

I affirm:

I understand that if I do not agree to the following points by completing the checkboxes my PR will be ignored.
I understand I should leave resolving conversations to the LandSandBoat team so that reviewers won't miss what was said.
I have read and understood the Contributing Guide and the Code of Conduct.
I have tested my code and the things my code has changed since the last commit in the PR and will test after any later commits.

What does this pull request do?

Initial draft for mobMagicalMove rework. Only modified one mobskill(Fireball (367) until the main function and its parameters are reviewed.

Adds support to mobMagicalMove:

Absorb/Nullification functionality.
Base Stat Attribute modifiers.
Bonus MACC/MATT inherent to the skill.
Option to ignore resistances/TDMA (Nether blast and some other skills)
dStat Multipliers. Not all skills use this but if defined then it will calculate it.
Option to define which stat attributes are compared in resist and dStat calculations. Its usually INT but there are some outliers that use MND for example.

Adds new parameter to xi.spells.damage.calculateMagicBonusDiff to allow passing of bonus MATT(Similar to existing bonusMacc in xi.combat.magicHitRate.calculateResistRate

Edit 10/30/2025:

Accidentally got my stash caught up in a rebase. Will submit future blocks of reworked mobskill scripts in separate commits.
Removed "Fire_Arrow.lua". This is not a skill with this name in the database. Its likely a redundant file meant to be "Flame_Arrow" which is an Orc Warmachine skill that is constantly mislabeled as "Fire Arrow" in EN language wikis.

Steps to test these changes

Toggle various settings, see no errors. See various params affect related functions.

scripts/actions/mobskills/fireball.lua

Xaver-DaRed · 2025-10-08T21:02:48Z

scripts/actions/mobskills/fireball.lua

+    params.mnd_wSC = { 0, 0, 0 }
+    params.chr_wSC = { 0, 0, 0 }
+
+    params.ignoreResist            = false


Other than non-elemental actions, I cannot think of a single action that bypasses resist states

The only edge case im aware of is that some skills can only be full duration or full resist, such as Leech attack down

Should only be TDMA then that gets bypassed?

Full duration or Full resist is enfeebling magic territory, and comes with a feature that already exists, called "resist states"

As for what should be bypassed and what shouldnt...

In the end we will have parameters to bypass every single step.
However, the default state of this bypasses should be "false"

What this means is that an action that does not bypass an step should not have the parameter defined at all, is my point.

I just put everything in here for testing. By default, it returns false if the param is missing from the script.

Edit: On note for above. Would it be preferable to have a param to skip each individual check (sdt, TMDA, etc)?

Update: Added individual params for toggling SDT/Resist/Damage Adjustment.

Xaver-DaRed · 2025-10-08T21:05:23Z

scripts/actions/mobskills/fireball.lua

+    params.resistStat              = xi.mod.INT
+    params.dStatMultiplier         = 1.5
+    params.dStatAttackerMod        = xi.mod.INT
+    params.dStatDefenderMod        = xi.mod.INT


Other than with Blind spell, I cant think of a single case of attacker and defender "stat" being different.
Which ok, that is an example.

However, resist stat?

leaden salute is your AGI vs their INT, i wouldn't completely rule it out

There are a few weaponskills that have different stat attribute checks like Leaden Salute and Primal Rend and some that have no stat comparisons at all. I imagine there are possible cases like this with mobskills too.

For magical resist calculations, is it always only INT checks for MACC?

iirc, it uses whatever stat you feed to it
and to my knowledge, it happens to be the same as the dStat... stat.
In this case, it would be the dStatAttackerMod

TLDR; to my knowledge, resistStat will always be the same as dStatAttackerMod

Okay, so we can delete resistStat and use the dStatMods instead to consolidate.

Do we just want to assume the comparison uses the same stat type(How it currently is now) or do we want to split it so that we can enter the attacker/defender's stats separately?

Mind you, I don't have current proof of mobskills that currently use separate stats like how some player weaponskills do. We could do it later if such a case comes up and just stick with current setup.

using diferent variables for the attacker and the defender dStats is fine

Update: Removed param.resiststat

almuth150 · 2025-10-08T21:55:52Z

re: Nether Blast, if it's like the player version, it does breath damage rather than magic damage. So I'm not sure if it fits into the magical mob move category, even though it uses a different calculation for breath damage than others.

Fwiw, there's an open issue for the player version of Nether Blast, since it's not being handled properly either, but I'm not going to link it here since you've been working on separating player BPs from mob skills.

UmeboshiXI · 2025-10-08T23:04:50Z

re: Nether Blast, if it's like the player version, it does breath damage rather than magic damage. So I'm not sure if it fits into the magical mob move category, even though it uses a different calculation for breath damage than others.

Fwiw, there's an open issue for the player version of Nether Blast, since it's not being handled properly either, but I'm not going to link it here since you've been working on separating player BPs from mob skills.

I'll wait and see if Frank can chime in, He probably knows more about avatar calcs. @Frankie-hz

Frankie-hz · 2025-10-09T13:14:27Z

Nerherblast is a fun one! It is indeed an unresisted breathe skill that has a static ftp of 5 and is effected by MAB/MDEF AND breathe damage taken. It will need a check on its own somewhere regardless because of the unresisted state.

UmeboshiXI · 2025-10-09T15:56:09Z

New update: Migrated Breath damage adjustments in mobBreathMove into their own function equivalent to TMDA in damageSpell. Used said function(xi.spells.damage.calculateTBDA) in mobBreathMove.

Also using this new function in mobMagicalMove for one off abilities like Nether Blast that use magic damage calcs but deal breath damage.

Also another note, would we want to eventually move modifiers like this to combat/damage_multipliers.lua?

sruon · 2025-10-30T16:27:42Z

I realize I should have left a comment earlier. I added the tests tag mostly because of the sheer size of the PR.

You don't have to do anything at this point, I will write some tests when the PR is ready.

Frankie-hz · 2025-10-31T06:30:02Z

scripts/globals/mobskills.lua

+    local strWSC = skillParams.str_wSC
+    local dexWSC = skillParams.dex_wSC
+    local vitWSC = skillParams.vit_wSC
+    local agiWSC = skillParams.agi_wSC
+    local intWSC = skillParams.int_wSC
+    local mndWSC = skillParams.mnd_wSC
+    local chrWSC = skillParams.chr_wSC


Where did you get that mobskills have weapon modifiers?

Will be there to be used for avatars whenever we rewrite those.

Frankie-hz · 2025-10-31T06:31:43Z

scripts/globals/mobskills.lua

+    -- Force a resist tier if defined.
+    if skillParams.resistTierOverride then
+        resistTier = resistTierOverride
+    end


Do you have an example of where this is used?

https://docs.google.com/spreadsheets/d/1YBoveP-weMdidrirY-vPDzHyxbEI2ryECINlfCnFkLI/edit?pli=1&gid=57955395#gid=57955395&range=A1102

Jimmayus spreadsheet said it was a guaranteed 1/4 resist when it backfires on the moblin.

UmeboshiXI · 2025-11-09T22:22:46Z

Sorry, taking a bit longer than anticipated. Been on retail past few days capturing data/mechanics for HP/MP/TP Drain skills. Should have the rest of the skills converted sometime this week.

github-actions · 2025-11-24T02:14:37Z

This PR has been automatically marked as stale because
it has not had recent activity. It will be closed if no
further activity occurs.

github-actions · 2025-12-25T02:14:33Z

This PR has been automatically marked as stale because
it has not had recent activity. It will be closed if no
further activity occurs.

UmeboshiXI force-pushed the Mobskills_Magical_Oct25 branch from cb9a7a9 to 9284999 Compare October 8, 2025 21:00

Xaver-DaRed reviewed Oct 8, 2025

View reviewed changes

scripts/actions/mobskills/fireball.lua Outdated Show resolved Hide resolved

Xaver-DaRed reviewed Oct 8, 2025

View reviewed changes

UmeboshiXI force-pushed the Mobskills_Magical_Oct25 branch from 9284999 to e28436a Compare October 9, 2025 00:14

UmeboshiXI force-pushed the Mobskills_Magical_Oct25 branch from e28436a to 2a7c498 Compare October 9, 2025 15:50

UmeboshiXI force-pushed the Mobskills_Magical_Oct25 branch 2 times, most recently from fa4f421 to 7fef004 Compare October 21, 2025 11:32

UmeboshiXI force-pushed the Mobskills_Magical_Oct25 branch 2 times, most recently from 3e8319f to 84c1b98 Compare October 30, 2025 14:12

UmeboshiXI changed the title ~~[lua] Mobskill Rework: Magical Skills~~ [lua, sql] Mobskill Rework: Magical Skills Oct 30, 2025

sruon added the needs tests Issue or PR is a good candidate for dedicated tests in xi_test label Oct 30, 2025

UmeboshiXI force-pushed the Mobskills_Magical_Oct25 branch from 84c1b98 to 0ab3475 Compare October 30, 2025 16:13

UmeboshiXI force-pushed the Mobskills_Magical_Oct25 branch 3 times, most recently from ab6acc1 to f1887c3 Compare October 30, 2025 20:02

Frankie-hz reviewed Oct 31, 2025

View reviewed changes

github-actions bot added the stale label Nov 24, 2025

UmeboshiXI force-pushed the Mobskills_Magical_Oct25 branch from f1887c3 to 958563a Compare December 8, 2025 23:39

github-actions bot removed the stale label Dec 10, 2025

UmeboshiXI added 2 commits December 16, 2025 00:12

[lua] Mobskill Rework: Magical

e812d33

[lua][sql] Correcting Amphiptere Knockback Skill ID

c051935

UmeboshiXI added 2 commits December 16, 2025 01:56

[lua] Magic Mobskill Rework 2/3

c6ffb4c

[lua] Magic Mobskill Rework 3/3

a0685fe

github-actions bot added the stale label Dec 25, 2025

UmeboshiXI force-pushed the Mobskills_Magical_Oct25 branch from ca0067d to a0685fe Compare January 24, 2026 22:38

github-actions bot removed the stale label Jan 25, 2026

[lua, sql] Mobskill Rework: Magical Skills #8360

Are you sure you want to change the base?

[lua, sql] Mobskill Rework: Magical Skills #8360

Conversation

UmeboshiXI commented Oct 8, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What does this pull request do?

Steps to test these changes

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

UmeboshiXI Oct 8, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

UmeboshiXI Oct 8, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

almuth150 commented Oct 8, 2025

Uh oh!

UmeboshiXI commented Oct 8, 2025

Uh oh!

Frankie-hz commented Oct 9, 2025

Uh oh!

UmeboshiXI commented Oct 9, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

sruon commented Oct 30, 2025

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

UmeboshiXI commented Nov 9, 2025

Uh oh!

github-actions bot commented Nov 24, 2025

Uh oh!

github-actions bot commented Dec 25, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

UmeboshiXI commented Oct 8, 2025 •

edited

Loading

UmeboshiXI Oct 8, 2025 •

edited

Loading

UmeboshiXI Oct 8, 2025 •

edited

Loading

UmeboshiXI commented Oct 9, 2025 •

edited

Loading