Skip to content

Conversation

@Frankie-hz
Copy link
Contributor

@Frankie-hz Frankie-hz commented Jan 25, 2026

I affirm:

  • I understand that if I do not agree to the following points by completing the checkboxes my PR will be ignored.
  • I understand I should leave resolving conversations to the LandSandBoat team so that reviewers won't miss what was said.
  • I have read and understood the Contributing Guide and the Code of Conduct.
  • I have tested my code and the things my code has changed since the last commit in the PR and will test after any later commits.

What does this pull request do?

Moves min/max levels from mob_groups.sql to mob_spawn_points.sql. Added Valkurm Dunes level changes as an example.

This will break all current DEs implemented without levels defined

Reason for this PR is because as we are doing mob level audits for every single zone there are 1-3 different level ranges for each type of mob. It looks like when the mob_groups was designed they were unaware that mob levels worked like this. Setting them to the mob_spawn_points allows us to differentiate the levels and not add 30-40 rows to each mob_group tables in the sql.

image image image

Steps to test these changes

Go to any mob in the game and check their levels.

To check DEs you can edit the fafnir.lua script.
If you remove the minLevel and maxLevel you will get an error with defaulted level to 255
image

@github-actions
Copy link

✨ Hello and thanks for the PR! ✨

🤖: This is a friendly automated reminder that the maintainers won't look at your PR until you've properly completed all of the checkboxes in the pre-filled template.

@Frankie-hz Frankie-hz marked this pull request as ready for review January 25, 2026 04:45
@Xaver-DaRed
Copy link
Contributor

YOLO

@Xaver-DaRed Xaver-DaRed merged commit 74ba9a7 into LandSandBoat:base Jan 25, 2026
10 checks passed
@Frankie-hz Frankie-hz deleted the levelstopoints branch January 26, 2026 05:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants