[숫자 야구 게임] 박지현 미션 제출합니다. #13
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
genius00hwan
reviewed
Jul 8, 2024
| for (int i = 0; i < 3; i++) { | ||
| do { | ||
| duplicate = false; | ||
| r[i] = Randoms.pickNumberInRange(1, 9); |
| import camp.nextstep.edu.missionutils.Randoms; | ||
|
|
||
| public class RandomNumber { | ||
| void randomNumber(int[] r){ |
Collaborator
There was a problem hiding this comment.
배열이 아닐 list를 사용해서 contains함수를 사용해보세요
| int countBall(int[] r, String[] str) { | ||
| for (int i = 0; i < 3; i++) { | ||
| for (int j = 0; j < 3; j++) { | ||
| if (i != j && r[i] == Integer.parseInt(str[j])) { |
Collaborator
There was a problem hiding this comment.
블록 들여쓰기가 너무 많으면 가독성이 떨어집니다. 메소드를 분리하거나 java 라이브러리 함수를 사용해보세요~~
genius00hwan
reviewed
Jul 8, 2024
| public class Application { | ||
| public static void main(String[] args) { | ||
| // TODO: 프로그램 구현 | ||
| Scanner scanner = new Scanner(System.in); |
Collaborator
There was a problem hiding this comment.
scanner 말고 과제에서 제공한 라이브러리에 있는 Console.read를 사용하세요
Collaborator
There was a problem hiding this comment.
안쓰는 객체를 생성할 필요가 있을까요?
| Scanner scanner = new Scanner(System.in); | ||
|
|
||
| System.out.println("숫자 야구 게임을 시작합니다."); | ||
| int[] randoms = new int[3]; |
Collaborator
There was a problem hiding this comment.
random넘버 배열을 RandomNumber에서 생성해도 될거 같아요
|
|
||
| while (true) { | ||
| try { | ||
| System.out.print("숫자를 입력해주세요 : "); |
Collaborator
There was a problem hiding this comment.
한 게임을 하는 기능이랑 게임을 재시작하는 기능을 분리할 수 있을거 같아요!
|
|
||
| String answer = Console.readLine(); | ||
| ExceptionHandler exceptionHandler = new ExceptionHandler(); | ||
| exceptionHandler.checkValid(answer); |
Collaborator
There was a problem hiding this comment.
예외처리 클래스를 만든것은 아주 좋은 생각이에요!!
| package baseball; | ||
|
|
||
| public class ExceptionHandler { | ||
| void checkValid(String answer){ |
Collaborator
There was a problem hiding this comment.
예외를 좀더 생각해보면서 다양한 경우를 생각해보세요!! 다양한 경우에 따라 메소드를 분리해보면 좀더 명확하겠죠?
genius00hwan
reviewed
Jul 8, 2024
|
|
||
| if (count.getStrikes() == 3) { | ||
| System.out.println("게임을 새로 시작하려면 1, 종료하려면 2를 입력하세요."); | ||
| int option = scanner.nextInt(); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
야구 게임