test(instrument): tier-2 test port for embedding (port-as-is)#146
Closed
mmercuri wants to merge 1 commit into
Closed
test(instrument): tier-2 test port for embedding (port-as-is)#146mmercuri wants to merge 1 commit into
mmercuri wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Port-as-is of the deeper unittest suite for the embedding adapter from
ateamintostratix-python.ateam/tests/adapters/test_embedding_adapter.py(183 LOC)tests/instrument/adapters/frameworks/test_embedding_adapter.py(mirrors flat layout used by agno / bedrock_agents / llama_index ports)feat/instrument-frameworks-agents(PR instrument: agent framework adapters (M1.C part 2) #97) — ownsembedding/adapter sourcesAdjustments (only what the shim demanded)
stratix.sdk.python.adapters.base→layerlens.instrument.adapters._base.adapter(forAdapterStatus)stratix.sdk.python.adapters.embedding.embedding_adapter→layerlens.instrument.adapters.frameworks.embedding.embedding_adapterstratix.sdk.python.adapters.embedding.vector_store_adapter→layerlens.instrument.adapters.frameworks.embedding.vector_store_adapterMockStratixin source — adapters are constructed bare (EmbeddingAdapter()/VectorStoreAdapter()) so transitionalorg_idpattern is not exercised here.Test count
TestEmbeddingAdapter+ 5TestVectorStoreAdapterget_adapter_info,serialize_for_replay, OpenAI/Cohere/SentenceTransformer wrap-and-emit, Pinecone/Chroma/Weaviate wrap-and-emitResult
No tests skipped, no @Skip applied, no rewrites.
Test plan
uv run --with pytest python -m pytest tests/instrument/adapters/frameworks/test_embedding_adapter.py -x— 14/14 pass