Skip to content

test(instrument): tier-2 test port for embedding (port-as-is)#146

Closed
mmercuri wants to merge 1 commit into
feat/instrument-frameworks-agentsfrom
feat/instrument-tier2-tests-embedding
Closed

test(instrument): tier-2 test port for embedding (port-as-is)#146
mmercuri wants to merge 1 commit into
feat/instrument-frameworks-agentsfrom
feat/instrument-tier2-tests-embedding

Conversation

@mmercuri

Copy link
Copy Markdown
Contributor

Summary

Port-as-is of the deeper unittest suite for the embedding adapter from ateam into stratix-python.

  • Source: ateam/tests/adapters/test_embedding_adapter.py (183 LOC)
  • Target: tests/instrument/adapters/frameworks/test_embedding_adapter.py (mirrors flat layout used by agno / bedrock_agents / llama_index ports)
  • Base branch: feat/instrument-frameworks-agents (PR instrument: agent framework adapters (M1.C part 2) #97) — owns embedding/ adapter sources

Adjustments (only what the shim demanded)

  • Imports rewritten:
    • stratix.sdk.python.adapters.baselayerlens.instrument.adapters._base.adapter (for AdapterStatus)
    • stratix.sdk.python.adapters.embedding.embedding_adapterlayerlens.instrument.adapters.frameworks.embedding.embedding_adapter
    • stratix.sdk.python.adapters.embedding.vector_store_adapterlayerlens.instrument.adapters.frameworks.embedding.vector_store_adapter
  • No MockStratix in source — adapters are constructed bare (EmbeddingAdapter() / VectorStoreAdapter()) so transitional org_id pattern is not exercised here.
  • All assertions, fixtures, and behaviors otherwise unchanged.

Test count

  • 14 tests total: 9 TestEmbeddingAdapter + 5 TestVectorStoreAdapter
  • Coverage: lifecycle (connect/disconnect/health), get_adapter_info, serialize_for_replay, OpenAI/Cohere/SentenceTransformer wrap-and-emit, Pinecone/Chroma/Weaviate wrap-and-emit

Result

14 passed in 2.30s

No tests skipped, no @Skip applied, no rewrites.

Test plan

  • uv run --with pytest python -m pytest tests/instrument/adapters/frameworks/test_embedding_adapter.py -x — 14/14 pass

@mmercuri mmercuri requested a review from m-peko May 10, 2026 16:25
@m-peko m-peko closed this May 21, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants