test(instrument): tier-2 test ports for ms_agent_framework + strands + pydantic_ai + smolagents (port-as-is)#149
Closed
mmercuri wants to merge 4 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Ports the deeper per-adapter test suites from ateam to stratix-python for the four lighter agent-framework adapters that live on
feat/instrument-frameworks-agents(PR #97). Strict port-as-is — only the adapter-shim renames described in each module docstring were applied.Source:
A:/github/layerlens/ateam/tests/adapters/<adapter>/(deeper per-adapter directories withconftest.py,test_lifecycle.py,test_events.py,test_integration.py, plustest_multi_agent.pyfor two adapters).Translation rules applied uniformly:
stratix.sdk.python.adapters.<adapter>.lifecycle->layerlens.instrument.adapters.frameworks.<adapter>.lifecyclestratix.sdk.python.adapters.base->layerlens.instrument.adapters._basestratix.sdk.python.adapters.capture.CaptureConfig->layerlens.instrument.adapters._base.CaptureConfigstratix.sdk.python.adapters.replay_models.ReplayableTrace->layerlens.instrument.adapters._base.ReplayableTracestratix.sdk.python.adapters.registry._ADAPTER_MODULES->layerlens.instrument.adapters._base.registry._ADAPTER_MODULES_stratix_originalwrapper marker ->_layerlens_original(rename done in adapter source on this branch)MockStratix/EventCollectortest stubs gain anorg_id = "test-org"attribute. Adapter constructors are still called WITHOUTorg_idkwarg. Mirrors langchain test(instrument): Port langchain dedicated test suites from ateam (close coverage gap) #127 / agno test(instrument): Port agno deeper test suites from ateam (tier 2) #134 / bedrock_agents test(instrument): Port bedrock_agents deeper test suites from ateam (tier 2) #135 / llama_index test(instrument): Port llama_index deeper test suites from ateam (tier 2) #136.ms_agent_framework
tests/instrument/adapters/frameworks/ms_agent_framework/@needs_semantic_kernelmarker ontest_connect_detects_sdk_version— semantic-kernel not installed in CI venv; port-as-is)pydantic_ai
tests/instrument/adapters/frameworks/pydantic_ai/pytest.importorskip("pydantic_ai")— pydantic-ai not installed; port-as-is)smolagents
tests/instrument/adapters/frameworks/smolagents/pytest.importorskip("smolagents")— smolagents not installed; port-as-is)strands
tests/instrument/adapters/frameworks/strands/pytest.importorskip("strands")— strands-agents not installed; port-as-is)Aggregate
uv run python -m pytest tests/instrument/adapters/frameworks/{ms_agent_framework,pydantic_ai,smolagents,strands}/ -rsAll 4 skips are
pytest.importorskip/@needs_<sdk>markers from the source. No tests were silently dropped, none were @pytest.mark.skip-added, and no assertions were weakened. The integration tests will exercise live when the respective optional SDKs are installed in a CI matrix that includes them.Test plan
uv run python -m pytest tests/instrument/adapters/frameworks/ms_agent_framework/ -rs-> 71 pass, 1 skipuv run python -m pytest tests/instrument/adapters/frameworks/pydantic_ai/ -rs-> 19 pass, 1 skipuv run python -m pytest tests/instrument/adapters/frameworks/smolagents/ -rs-> 19 pass, 1 skipuv run python -m pytest tests/instrument/adapters/frameworks/strands/ -rs-> 29 pass, 1 skipRebase note
Once #118 lands, a follow-up sweep PR will rebase the
MockStratix.org_id/EventCollector.org_idattribute pattern to the canonicalorg_idconstructor kwarg.