Conversation
* models: update_custom + delete_custom, fix add/remove filter Companion to atlas-app PR #1916. Three concrete behavior changes: 1. add() / remove() now operate on the full project model list (public + custom). The previous type="public" filter silently dropped custom-model IDs from Project.Models on every call. 2. New update_custom(model_id, *, api_url, api_key, max_tokens) — the customer's primary workflow: repoint api_url for ephemeral vLLM endpoints behind cloudflared tunnels whose hostname changes between sessions. 3. New delete_custom(model_id) — full teardown: disables the record, strips it from Project.Models, releases the name for reuse. Mirrors all three in AsyncModels. Adds unit tests (12 new in test_models_resource.py) and a @pytest.mark.live lifecycle test in test_models_custom_live.py. Docs and the custom_model sample now exercise update + delete. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> * style: apply ruff format CI's format check insists on these two cosmetic adjustments. No behavior change. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> * chore: bump version to 1.6.1 Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.