Feat | LAY-885 cicd publish#7
Conversation
|
|
||
| env: | ||
| TWINE_USERNAME: __token__ | ||
| TWINE_PASSWORD: ${{ secrets.TWINE_PASSWORD }} |
There was a problem hiding this comment.
What is TWINE? Is that something we setup on Pypi?
There was a problem hiding this comment.
Twine is the utility used to publish the packages to pypi: https://pypi.org/project/twine/
It is used here: https://github.com/LayerLens/atlas-python/pull/7/files#diff-c63759f58a022cf694046a961470c6e28c042d8f221646bc5ddbb5fa959dda75R24
| name: Publish Python SDK | ||
|
|
||
| on: | ||
| push: |
There was a problem hiding this comment.
Can we make sure this only runs on the release-branch?
This should never run on main.
There was a problem hiding this comment.
This action runs when a new tag is pushed. The tag must follow this pattern sdk-v*.*.* for this action to run.
Then the publish script makes sure we are working with the release branch
| tags: | ||
| - "sdk-v*.*.*" # Trigger on version tags like sdk-v0.1.0 etc. | ||
|
|
||
| jobs: |
There was a problem hiding this comment.
Can you make sure this job runs on our production github enviornment?
That way it need manual approval before it can run. Like we do in the atlas-app: https://github.com/LayerLens/atlas-app/blob/main/.github/workflows/deploy-production-backend.yaml#L12
| name: Create Release Tag | ||
|
|
||
| on: | ||
| workflow_dispatch: |
There was a problem hiding this comment.
Can we make sure this only can be run on the release branch + in the production enviornment so we ensure manual review is needed for publishing?
|
|
||
| on: | ||
| workflow_dispatch: | ||
| inputs: |
There was a problem hiding this comment.
How do we specify major vs minor vs patch releases?
There was a problem hiding this comment.
With the current setup we have, I think we should manually bump the version in the _version file, then release the tag.
At least AFAIK that's the approach of braintrust seeing their PRs
Lzok
force-pushed
the
feat/LAY-885-cicd-publish
branch
from
5572988 to
ea80fb7
Compare
m-peko
force-pushed
the
feat/LAY-885-cicd-publish
branch
from
ea80fb7 to
9afc371
Compare
3 participants
No description provided.