feat | LAY-896 Added pagination for results resource. Updated and add…#8
Conversation
…ed unit tests where coverage was missing. Updated docs.
| import gc | ||
| from atlas import Atlas | ||
|
|
||
| def memory_efficient_processing(evaluation_id: str): |
There was a problem hiding this comment.
I don't think this one is needed.
| min_toxicity_score: Optional[float] | ||
| max_toxicity_score: Optional[float] | ||
| min_readability_score: Optional[float] | ||
| max_readability_score: Optional[float] |
There was a problem hiding this comment.
The format of the metrics are a key:value pair of metricName: float value.
Right now the supported metrics are:
- readability
- toxicity
- hallucination
The results themselves have metric values and not a range. See results here for example: https://app.layerlens.ai/evaluations/689343c659f37b1398a677b2
There was a problem hiding this comment.
We have two metric properties here. One is "global", in the parent object. They are optional because some configurable metrics could not be present.
The other metrics are the ones inside each result. Both of them are mapped in the models.
Do we want to remove the parent ones?
There was a problem hiding this comment.
Yep here we are dealing with the Results entity here so the later in the image.
There was a problem hiding this comment.
Metrics should be the key:value map of floats.
| page: Optional[int] = None, | ||
| page_size: Optional[int] = None, |
There was a problem hiding this comment.
Do we need default values here? Like defaulting to the first page of results?
…ources. Removed memory mgmnt docs. Added unit test for the default page behavior
2 participants
…ed unit tests where coverage was missing. Updated docs.