Fix basePath handling in useInterceptLinkClicks#43
Open
jacobrobertsbaca wants to merge 1 commit intoLayerXcom:mainfrom
Open
Fix basePath handling in useInterceptLinkClicks#43jacobrobertsbaca wants to merge 1 commit intoLayerXcom:mainfrom
jacobrobertsbaca wants to merge 1 commit intoLayerXcom:mainfrom
Conversation
peinguin
approved these changes
Sep 1, 2025
|
when will this fix be released? |
|
Hi @jacobrobertsbaca and @ypresto, Just wanted to follow up on this PR — is there any update on its status? We’re currently blocked from using this library in production due to the basePath issue in the App Router, so we’re really hoping this fix can be merged. Please let us know if any additional changes or testing would help move this forward. Thanks for your work on this! |
|
Seems to work when adding as a patch 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes the
basePathhandling mentioned in #41 where the App router link interceptor adds the basePath twice.Unfortunately, the NextJS app router no longer makes
basePathaccessible (see this page) so removing the extra path segments is not as simple as usingrouter.basePath. Instead, we need to render a node and see what the resulting<a />tag'shrefattribute looks like.I have tested this on my own local site with 1) no base path set and 2) a base path set. Both methods are working.