-
Notifications
You must be signed in to change notification settings - Fork 260
DEVREL-1159 feat(wiring): for solana, display txn data as base58 #1901
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
🧪 E2E Test StatusE2E tests are non-blocking and validate real blockchain interactions. Failures may occur due to network issues, RPC rate limits, or external service downtime. Test Runs (Newest First): |
PR SummaryMakes Solana transactions easier to consume by formatting data as base58 instead of hex.
Written by Cursor Bugbot for commit 9015d7c. This will update automatically on new commits. Configure here. |
St0rmBr3w
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
shankars99
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
St0rmBr3w
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Problem
Solution
Changes
packages/devtools/src/transactions/format.ts:isSolanaEidhelper to check if an endpoint is Solana.formatTransactionDatato convert hex to base58 for Solana transactions.formatOmniTransactionto use the new data formatting.packages/ua-devtools-evm-hardhat/src/tasks/oapp/wire/index.ts:formatOmniTransactionwhen writing transactions to output file.Before and After
Before (npx lz:oapp:wire --oapp-config layerzero.config.ts --output-file txns.json):
After (npx lz:oapp:wire --oapp-config layerzero.config.ts --output-file txns.json):