-
Notifications
You must be signed in to change notification settings - Fork 260
DEVREL-1186 devtools QoL batch 1 #1906
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
🧪 E2E Test StatusE2E tests are non-blocking and validate real blockchain interactions. Failures may occur due to network issues, RPC rate limits, or external service downtime. Test Runs (Newest First): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR addresses three bugs related to DevTools quality-of-life improvements: misleading "already wired" messages for Solana init tasks, broken config retrieval in upgradeable examples, and unclear feedback when deploy tags don't match any scripts.
Changes:
- Added configurable
noActionMessageparameter to wire flow for custom completion messages - Enhanced deploy task with tag validation and warnings for unmatched tags or no deployments
- Removed unnecessary
TS_NODE_COMPILER_OPTIONSenvironment variable from Solana examples - Added audit documentation links to Solana OFT example
Reviewed changes
Copilot reviewed 13 out of 13 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| turbo.json | Added TypeScript-related environment variables to global pass-through configuration |
| tests/devtools-evm-hardhat-test/test/task/deploy.test.expectations/deploy-all-missing-tag.exp | Updated test expectations to validate new warning messages for missing tags and no deployments |
| packages/ua-devtools-evm-hardhat/src/tasks/oapp/wire/index.ts | Added noActionMessage parameter to wire task for customizable completion messages |
| packages/devtools/src/flows/wire.ts | Implemented noActionMessage parameter in wire flow with default value |
| packages/devtools-evm-hardhat/src/tasks/deploy.ts | Added tag validation, available tags discovery, and warnings for unmatched tags or zero deployments |
| examples/oft-solana/tasks/solana/initConfig.ts | Applied custom "Pathway config already initialized" message and removed TODO comment |
| examples/oft-solana/hardhat.config.ts | Removed unnecessary TS_NODE_COMPILER_OPTIONS environment variable setup |
| examples/oft-solana/README.md | Added audits section with commit hash and links to audit reports |
| examples/oapp-solana/tasks/solana/initConfig.ts | Applied custom completion message for consistency with oft-solana |
| examples/oapp-solana/hardhat.config.ts | Removed unnecessary TS_NODE_COMPILER_OPTIONS environment variable setup |
| examples/lzapp-migration/tasks/solana/initConfig.ts | Applied custom completion message and removed duplicate comment |
| docs/EXAMPLES_SPECS.md | Added specification for optional Audits section in example READMEs |
| .changeset/gorgeous-cobras-pull.md | Added changeset documenting the fix for misleading init-config messages |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
PR SummaryImproves DX around configuration/wiring and deployments; minor docs/examples updates.
Written by Cursor Bugbot for commit 607c6e1. This will update automatically on new commits. Configure here. |
Problems
Closes #1155 - bug: Re-running npx hardhat lz:oapp:init:solana returns "OApp is wired, no action is necessary" when it's in fact not wired.
Closes #1028 - bug: npx hardhat lz:oapp:config:get:default broken in upgradeable example
Closes #1066 - bug: lz:deploy requires deploy task name matches contractName
#1155 - bug: Re-running npx hardhat lz:oapp:init:solana returns "OApp is wired, no action is necessary" when it's in fact not wired.
Changes
packages/devtools/src/flows/wire.ts: added configurablenoActionMessageparameter.packages/ua-devtools-evm-hardhat/src/tasks/oapp/wire/index.ts: threadednoActionMessagethrough the task.examples/oft-solana/tasks/solana/initConfig.ts: passed custom message and removed TODO.examples/lzapp-migration/tasks/solana/initConfig.ts: passed custom message for consistency.Example run
How to test
devtoolslocally.examples/oft-solana, go through the usual deployment steps.#1028 - bug: npx hardhat lz:oapp:config:get:default broken in upgradeable example
Changes
hardhat.config.ts, commented outdeploymentSourcePackages: [].#1066 - bug: lz:deploy requires deploy task name matches contractName
Changes
Example run
examples/oft $ npx hardhat lz:deploy --tags s ╭─────────────────────────────────────────╮ │ ▓▓▓ LayerZero DevTools ▓▓▓ │ │ ═══════════════════════════════════ │ │ /*\ │ │ /* *\ BUILD ANYTHING │ │ ('v') │ │ //-=-\\ ▶ OMNICHAIN │ │ (\_=_/) │ │ ^^ ^^ │ │ ▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓ │ ╰─────────────────────────────────────────╯ info: Compiling your hardhat project Nothing to compile ✔ Which networks would you like to deploy? › arbitrum-sepolia, base-sepolia ✔ Which deploy script tags would you like to use? … s info: Will deploy 2 networks: arbitrum-sepolia, base-sepolia info: Will use deploy scripts tagged with s warn: The following tags do not match any deploy scripts: s. Available tags: DestinationExecutorMock, MyOFT, SimpleDVNMock, SimpleExecutorMock ✔ Do you want to continue? … yes warn: ⤫ No contracts were deployed. This could mean the deploy script tags don't match any scripts, or all contracts were already deployed.Other changes
TS_NODE_COMPILER_OPTIONSenv var in Solana examples.devtools/examples/oft-solana: added links to audits.TS_NODE_FILESandTS_NODE_PROJECTtoturbo.jsonglobalPassThroughEnv.