Skip to content

Conversation

@nazreen
Copy link
Contributor

@nazreen nazreen commented Jan 21, 2026

Problem

  • pre-Simple Config, create-lz-oapp already supported the --skip-connections-from-eids param
  • generateConnectionsConfig fails when pathways include chains without DVN metadata (e.g., Starknet).
  • The --skip-connections-from-eids CLI flag only filters after config loading.
  • DVN lookups still fail during config generation before filtering can occur.

Changes

  • Added skipFromEids parameter to generateConnectionsConfig and translatePathwayToConfig.
  • Located in packages/metadata-tools/src/config-metadata.ts.
  • Filters pathways before DVN/executor lookups, skipping chains that lack metadata.
  • Added 3 tests in packages/metadata-tools/test/config-metadata.test.ts.

@socket-security
Copy link

Review the following changes in direct dependencies. Learn more about Socket for GitHub.

Diff Package Supply Chain
Security
Vulnerability Quality Maintenance License
Updatednpm/​@​layerzerolabs/​devtools-solana@​3.0.4 ⏵ 3.0.67110081 +193 -1100

View full report

@github-actions
Copy link
Contributor

🧪 E2E Test Status

E2E tests are non-blocking and validate real blockchain interactions. Failures may occur due to network issues, RPC rate limits, or external service downtime.

Test Runs (Newest First):

  • Run #6603 - Passed - 2026-01-21 23:38 (UTC)

@nazreen nazreen marked this pull request as ready for review January 22, 2026 00:17
@cursor
Copy link

cursor bot commented Jan 22, 2026

PR Summary

metadata-tools

  • Adds skipFromEids to generateConnectionsConfig and translatePathwayToConfig to pre-filter directions before DVN/executor lookups
  • Generates only non-skipped A→B or B→A configs; returns none if both skipped
  • Updates logic to only resolve deployments/DVNs/executors for non-skipped sides
  • Adds 3 tests covering skipping behavior and DVN lookup avoidance

devtools

  • Adds ChainType.STARKNET handling in normalizePeer/denormalizePeer

misc

  • Bumps Solana devtools-related versions in example lockfiles
  • Adds changeset for @layerzerolabs/metadata-tools patch release

Written by Cursor Bugbot for commit 4ce0bff. This will update automatically on new commits. Configure here.

Copy link
Contributor

@St0rmBr3w St0rmBr3w left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@nazreen nazreen enabled auto-merge January 22, 2026 00:29
@nazreen nazreen requested a review from DanL0 January 22, 2026 00:30
@nazreen nazreen added this pull request to the merge queue Jan 22, 2026
Merged via the queue into main with commit 01b911a Jan 22, 2026
31 checks passed
@nazreen nazreen deleted the simple-config-skip-eids branch January 22, 2026 08:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants