Conversation
LazyTarget
commented
Mar 8, 2025
- linting
- release-drafter
- sourcery
- pre-commit
Reviewer's Guide by SourceryThis pull request includes several key updates: the package was renamed from No diagrams generated as the changes look simple and do not need a visual representation. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Hey @LazyTarget - I've reviewed your changes - here's some feedback:
Overall Comments:
- Consider adding a more specific exception when the content type is not JSON.
- The addition of
__aenter__and__aexit__makes the API class usable as a context manager, which is great.
Here's what I looked at during the review
- 🟡 General issues: 1 issue found
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
| pip3 install pyopenhardwaremonitor | ||
| ``` | ||
|
|
||
| ## Example |
There was a problem hiding this comment.
suggestion: Mention the new example file.
Consider adding a sentence like "A more detailed example can be found in example.py" to the README to point readers to the new example file.
| ## Example | |
| ## Example | |
| A more detailed example can be found in `example.py` |