fix: include fixed-size arrays in ABI schema paths#287
Closed
Maroutis wants to merge 5 commits intoLedgerHQ:mainfrom
Closed
fix: include fixed-size arrays in ABI schema paths#287Maroutis wants to merge 5 commits intoLedgerHQ:mainfrom
Maroutis wants to merge 5 commits intoLedgerHQ:mainfrom
Conversation
## Summary - The Lark grammar for ABI signature parsing only handled dynamic arrays (`[]`) but rejected fixed-size arrays (`[N]`), causing lint failures on valid Solidity types like `address[11]`, `uint256[5][5]`, and `address[5]`. - Extended the `array` grammar rule to accept both `[]` and `[N]`, updated the `array` transformer to preserve the size, and fixed the `named_tuple` filter to correctly identify fixed-size array suffixes. - Added 5 test cases covering single-dimension, multi-dimension, mixed fixed/dynamic, tuple, and 3D fixed-size arrays. ## Test plan - [x] Existing `test_reduce_signature` parametrized tests still pass (no regressions) - [x] New test cases pass: `address[11]`, `uint256[5][5]`, `uint256[3]`, `bytes32[2][]`, `(uint256,address)[3]`, `uint256[2][3][4]` - [x] `erc7730 lint calldata-curve.json` no longer errors on the Curve router signature Made with [Cursor](https://cursor.com)
Count fixed-size array dimensions when deriving ABI schema paths so display-field validation can match indexed fixed-array references like `_route.[0]`. Add regressions for fixed-size scalar arrays and tuple arrays to keep dynamic-array behavior unchanged. Made-with: Cursor
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
_route.[0]and multidimensional fixed arrays to resolve to valid ABI schema pathsTest plan
PYTHONPATH=src python -m pytest -o addopts='' tests/model/paths/test_path_schemas.py tests/common/test_abi.pycompute_abi_schema_paths()now includes#._route.[]and#._swap_params.[].[]for a Curve-like fixed-array signaturecalldata-test.jsonwith a mocked ABI and confirmed the previous invalid#._route.[]error disappearsMade with Cursor