fix: EIP-712 domain name is required for legacy EIP-712 conversion#288
Closed
ckorchane-ledger wants to merge 1 commit intomainfrom
Closed
fix: EIP-712 domain name is required for legacy EIP-712 conversion#288ckorchane-ledger wants to merge 1 commit intomainfrom
ckorchane-ledger wants to merge 1 commit intomainfrom
Conversation
Contributor
Author
|
duplicate of PR 283 closing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
eip712-Safe-1.3.0.json after includes are resolved:
{ "$schema": "../../specs/erc7730-v2.schema.json", "metadata": { "owner": "Safe 1.3.0" }, "context": { "eip712": { "deployments": [...] } } }There is no domain in the EIP-712 context. The v2 converter requires it:
Since domain is None, dapp_name is None, and the converter returns an error