fix: accept scalar values in v2 visibility rules#290
Closed
Maroutis wants to merge 5 commits intoLedgerHQ:mainfrom
Closed
fix: accept scalar values in v2 visibility rules#290Maroutis wants to merge 5 commits intoLedgerHQ:mainfrom
Maroutis wants to merge 5 commits intoLedgerHQ:mainfrom
Conversation
## Summary - The Lark grammar for ABI signature parsing only handled dynamic arrays (`[]`) but rejected fixed-size arrays (`[N]`), causing lint failures on valid Solidity types like `address[11]`, `uint256[5][5]`, and `address[5]`. - Extended the `array` grammar rule to accept both `[]` and `[N]`, updated the `array` transformer to preserve the size, and fixed the `named_tuple` filter to correctly identify fixed-size array suffixes. - Added 5 test cases covering single-dimension, multi-dimension, mixed fixed/dynamic, tuple, and 3D fixed-size arrays. ## Test plan - [x] Existing `test_reduce_signature` parametrized tests still pass (no regressions) - [x] New test cases pass: `address[11]`, `uint256[5][5]`, `uint256[3]`, `bytes32[2][]`, `(uint256,address)[3]`, `uint256[2][3][4]` - [x] `erc7730 lint calldata-curve.json` no longer errors on the Curve router signature Made with [Cursor](https://cursor.com)
Align the v2 visibility models with the schema so mustBe/ifNotIn accept numbers and booleans instead of rejecting valid descriptors during lint resolution. Made-with: Cursor
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
mustBeandifNotInaccept scalar values, not just stringsmustBerules in the existing v2 resolved-conversion fixture100,true, orfalseTest plan
uv run --with prettydiff pytest -o addopts='' tests/v2/convert/resolved/test_convert_input_to_resolved.py -k visibility_conditions -quv run --with prettydiff pytest -o addopts='' tests/model/paths/test_path_schemas.py -quv run erc7730 lint /tmp/calldata-visibility-scalar.jsonon a temp v2 descriptor usingmustBe: [100]andmustBe: [true](only ABI-key warning remained)Made with Cursor